From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rickard Strandqvist Date: Sun, 06 Jul 2014 17:35:48 +0000 Subject: [PATCH] video: fbdev: omap2: dss: display-sysfs.c: Cleaning up wrong type in format string Message-Id: <1404668148-15112-1-git-send-email-rickard_strandqvist@spectrumdigital.se> List-Id: References: <1404566258-22901-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1404566258-22901-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Jingoo Han , Laurent Pinchart , Rob Clark , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Wrong type in printf format string, requires 'unsigned int' but the argument type is 'int' This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/omap2/dss/display-sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/omap2/dss/display-sysfs.c b/drivers/video/fbdev/omap2/dss/display-sysfs.c index 5a2095a..5928bc9 100644 --- a/drivers/video/fbdev/omap2/dss/display-sysfs.c +++ b/drivers/video/fbdev/omap2/dss/display-sysfs.c @@ -184,7 +184,7 @@ static ssize_t display_rotate_show(struct device *dev, if (!dssdev->driver->get_rotate) return -ENOENT; rotate = dssdev->driver->get_rotate(dssdev); - return snprintf(buf, PAGE_SIZE, "%u\n", rotate); + return snprintf(buf, PAGE_SIZE, "%d\n", rotate); } static ssize_t display_rotate_store(struct device *dev, @@ -215,7 +215,7 @@ static ssize_t display_mirror_show(struct device *dev, if (!dssdev->driver->get_mirror) return -ENOENT; mirror = dssdev->driver->get_mirror(dssdev); - return snprintf(buf, PAGE_SIZE, "%u\n", mirror); + return snprintf(buf, PAGE_SIZE, "%d\n", mirror); } static ssize_t display_mirror_store(struct device *dev, -- 1.7.10.4