Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
To: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	Jingoo Han <jg1.han@samsung.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Rob Clark <robdclark@gmail.com>,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] video: fbdev: msm: mddi.c:  Cleaning up variable that is never used
Date: Sun, 06 Jul 2014 18:42:28 +0000	[thread overview]
Message-ID: <1404672148-19061-1-git-send-email-rickard_strandqvist@spectrumdigital.se> (raw)
In-Reply-To: <1404563514-20355-1-git-send-email-rickard_strandqvist@spectrumdigital.se>

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/video/fbdev/msm/mddi.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/msm/mddi.c b/drivers/video/fbdev/msm/mddi.c
index e0f8011..d65ff75a 100644
--- a/drivers/video/fbdev/msm/mddi.c
+++ b/drivers/video/fbdev/msm/mddi.c
@@ -257,12 +257,12 @@ static irqreturn_t mddi_isr(int irq, void *data)
 	struct msm_mddi_client_data *cdata = data;
 	struct mddi_info *mddi = container_of(cdata, struct mddi_info,
 					      client_data);
-	uint32_t active, status;
+	uint32_t active;
 
 	spin_lock(&mddi->int_lock);
 
 	active = mddi_readl(INT);
-	status = mddi_readl(STAT);
+	mddi_readl(STAT);
 
 	mddi_writel(active, INT);
 
@@ -548,7 +548,6 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
 	struct mddi_llentry *ll;
 	struct mddi_register_access *ra;
 	struct reg_read_info ri;
-	unsigned s;
 	int retry_count = 2;
 	unsigned long irq_flags;
 
@@ -572,7 +571,7 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
 	ll->next = 0;
 	ll->reserved = 0;
 
-	s = mddi_readl(STAT);
+	mddi_readl(STAT);
 
 	ri.reg = reg;
 	ri.status = -1;
-- 
1.7.10.4


      reply	other threads:[~2014-07-06 18:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-05 12:31 [PATCH] video: fbdev: msm: mddi.c: Cleaning up variable that is never used Rickard Strandqvist
2014-07-06 18:42 ` Rickard Strandqvist [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404672148-19061-1-git-send-email-rickard_strandqvist@spectrumdigital.se \
    --to=rickard_strandqvist@spectrumdigital.se \
    --cc=jg1.han@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=robdclark@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox