* [PATCH] video: amba-clcd: Select FB_MODE_HELPERS
@ 2014-08-01 15:53 Mark Brown
2014-08-01 18:27 ` Russell King - ARM Linux
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mark Brown @ 2014-08-01 15:53 UTC (permalink / raw)
To: linux-fbdev
From: Mark Brown <broonie@linaro.org>
The AMBA CLCD driver uses fb_videomode_from_videomode() so it needs to
select DB_MODE_HELPERS as well as VIDEOMODE_HELPERS.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
drivers/video/fbdev/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 37d473f..e222048 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -280,6 +280,7 @@ config FB_ARMCLCD
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
+ select FB_MODE_HELPERS
select VIDEOMODE_HELPERS if OF
help
This framebuffer device driver is for the ARM PrimeCell PL110
--
2.0.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] video: amba-clcd: Select FB_MODE_HELPERS
2014-08-01 15:53 [PATCH] video: amba-clcd: Select FB_MODE_HELPERS Mark Brown
@ 2014-08-01 18:27 ` Russell King - ARM Linux
2014-08-01 18:48 ` Mark Brown
2014-08-04 6:48 ` Tomi Valkeinen
2 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2014-08-01 18:27 UTC (permalink / raw)
To: linux-fbdev
On Fri, Aug 01, 2014 at 04:53:50PM +0100, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The AMBA CLCD driver uses fb_videomode_from_videomode() so it needs to
> select DB_MODE_HELPERS as well as VIDEOMODE_HELPERS.
It doesn't, not as I designed it at least. It depends what other people
have done to my driver...
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] video: amba-clcd: Select FB_MODE_HELPERS
2014-08-01 15:53 [PATCH] video: amba-clcd: Select FB_MODE_HELPERS Mark Brown
2014-08-01 18:27 ` Russell King - ARM Linux
@ 2014-08-01 18:48 ` Mark Brown
2014-08-04 6:48 ` Tomi Valkeinen
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-08-01 18:48 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Fri, Aug 01, 2014 at 07:27:03PM +0100, Russell King - ARM Linux wrote:
> On Fri, Aug 01, 2014 at 04:53:50PM +0100, Mark Brown wrote:
> > The AMBA CLCD driver uses fb_videomode_from_videomode() so it needs to
> > select DB_MODE_HELPERS as well as VIDEOMODE_HELPERS.
> It doesn't, not as I designed it at least. It depends what other people
> have done to my driver...
Ah, sorry - I didn't notice that this is as a result of an out of tree
patch I'm carrying adding DT support (which I'd forgotten all about as
I've needed it for so long). Please disregard this patch.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] video: amba-clcd: Select FB_MODE_HELPERS
2014-08-01 15:53 [PATCH] video: amba-clcd: Select FB_MODE_HELPERS Mark Brown
2014-08-01 18:27 ` Russell King - ARM Linux
2014-08-01 18:48 ` Mark Brown
@ 2014-08-04 6:48 ` Tomi Valkeinen
2 siblings, 0 replies; 4+ messages in thread
From: Tomi Valkeinen @ 2014-08-04 6:48 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
Hi,
On 01/08/14 18:53, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The AMBA CLCD driver uses fb_videomode_from_videomode() so it needs to
> select DB_MODE_HELPERS as well as VIDEOMODE_HELPERS.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/video/fbdev/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 37d473f..e222048 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -280,6 +280,7 @@ config FB_ARMCLCD
> select FB_CFB_FILLRECT
> select FB_CFB_COPYAREA
> select FB_CFB_IMAGEBLIT
> + select FB_MODE_HELPERS
> select VIDEOMODE_HELPERS if OF
> help
> This framebuffer device driver is for the ARM PrimeCell PL110
Pawel sent a patch fixing the same issue. I've applied that one.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-04 6:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-01 15:53 [PATCH] video: amba-clcd: Select FB_MODE_HELPERS Mark Brown
2014-08-01 18:27 ` Russell King - ARM Linux
2014-08-01 18:48 ` Mark Brown
2014-08-04 6:48 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).