From: Pawel Moll <pawel.moll@arm.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] video: ARM CLCD: Fix calculation of bits-per-pixel
Date: Wed, 20 Aug 2014 13:03:07 +0000 [thread overview]
Message-ID: <1408539787.21533.79.camel@hornet> (raw)
In-Reply-To: <1408538464.3858.43.camel@linaro1.home>
On Wed, 2014-08-20 at 13:41 +0100, Jon Medhurst (Tixy) wrote:
> If the device-tree specifies a max-memory-bandwidth property then the
> CLCD driver uses that to calculate the bits-per-pixel supported,
> however, this calculation is faulty for two reasons.
>
> 1. It doesn't ensure that the result is a sane value, i.e. a power of 2
> and <= 32 as the rest of the code assumes.
>
> 2. It uses the displayed resolution and calculates the average bandwidth
> across the whole frame. It should instead calculate the peak
> bandwidth based on the pixel clock.
>
> This patch fixes both the above.
>
> Signed-off-by: Jon Medhurst <tixy@linaro.org>
Acked-by: Pawel Moll <pawel.moll@arm.com>
next prev parent reply other threads:[~2014-08-20 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 12:41 [PATCH v2] video: ARM CLCD: Fix calculation of bits-per-pixel Jon Medhurst (Tixy)
2014-08-20 13:03 ` Pawel Moll [this message]
2014-08-26 9:52 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408539787.21533.79.camel@hornet \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).