* [PATCH] video: valkyriefb: Fix unused variable warning in set_valkyrie_clock()
@ 2014-09-14 9:48 Geert Uytterhoeven
2014-09-30 9:43 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2014-09-14 9:48 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: linux-fbdev, linux-m68k, linuxppc-dev, Geert Uytterhoeven
If CONFIG_ADB_CUDA=n:
drivers/video/fbdev/valkyriefb.c: In function ‘set_valkyrie_clock’:
drivers/video/fbdev/valkyriefb.c:267: warning: unused variable ‘i’
drivers/video/fbdev/valkyriefb.c:266: warning: unused variable ‘req’
Move the variable declarations inside the existing #ifdef section to fix
this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/video/fbdev/valkyriefb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c
index 97cb9bd1d1dd..b6ed09f16355 100644
--- a/drivers/video/fbdev/valkyriefb.c
+++ b/drivers/video/fbdev/valkyriefb.c
@@ -263,10 +263,10 @@ static inline int valkyrie_vram_reqd(int video_mode, int color_mode)
static void set_valkyrie_clock(unsigned char *params)
{
+#ifdef CONFIG_ADB_CUDA
struct adb_request req;
int i;
-#ifdef CONFIG_ADB_CUDA
for (i = 0; i < 3; ++i) {
cuda_request(&req, NULL, 5, CUDA_PACKET, CUDA_GET_SET_IIC,
0x50, i + 1, params[i]);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] video: valkyriefb: Fix unused variable warning in set_valkyrie_clock()
2014-09-14 9:48 [PATCH] video: valkyriefb: Fix unused variable warning in set_valkyrie_clock() Geert Uytterhoeven
@ 2014-09-30 9:43 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2014-09-30 9:43 UTC (permalink / raw)
To: Geert Uytterhoeven, Jean-Christophe Plagniol-Villard
Cc: linux-fbdev, linux-m68k, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On 14/09/14 12:48, Geert Uytterhoeven wrote:
> If CONFIG_ADB_CUDA=n:
>
> drivers/video/fbdev/valkyriefb.c: In function ‘set_valkyrie_clock’:
> drivers/video/fbdev/valkyriefb.c:267: warning: unused variable ‘i’
> drivers/video/fbdev/valkyriefb.c:266: warning: unused variable ‘req’
>
> Move the variable declarations inside the existing #ifdef section to fix
> this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/video/fbdev/valkyriefb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c
> index 97cb9bd1d1dd..b6ed09f16355 100644
> --- a/drivers/video/fbdev/valkyriefb.c
> +++ b/drivers/video/fbdev/valkyriefb.c
> @@ -263,10 +263,10 @@ static inline int valkyrie_vram_reqd(int video_mode, int color_mode)
>
> static void set_valkyrie_clock(unsigned char *params)
> {
> +#ifdef CONFIG_ADB_CUDA
> struct adb_request req;
> int i;
>
> -#ifdef CONFIG_ADB_CUDA
> for (i = 0; i < 3; ++i) {
> cuda_request(&req, NULL, 5, CUDA_PACKET, CUDA_GET_SET_IIC,
> 0x50, i + 1, params[i]);
>
Thanks, queued for 3.18.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-30 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-14 9:48 [PATCH] video: valkyriefb: Fix unused variable warning in set_valkyrie_clock() Geert Uytterhoeven
2014-09-30 9:43 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).