* [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper
@ 2014-09-24 16:26 Vinod Koul
2014-09-24 16:27 ` [PATCH 27/27] video: fbdev: use pm_runtime_last_busy_and_autosuspend helper Vinod Koul
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Vinod Koul @ 2014-09-24 16:26 UTC (permalink / raw)
To: linux-kernel
Cc: linux-wireless, Baruch Siach, patches, linux-doc, Seungwon Jeon,
Daniel Vetter, Chris Ball, dri-devel, Marcin Wojtas,
Rafael J. Wysocki, Laurent Pinchart, David Herrmann,
Shinya Kuribayashi, Laurent Pinchart, vinod.koul, Jingoo Han,
Jaehoon Chung, Jani Nikula, Tomi Valkeinen, Alan Stern,
Ben Skeggs, Bjorn Andersson, Wolfram Sang
This patch series adds a simple macro pm_runtime_last_busy_and_autosuspend()
which invokes pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend()
sequentially. Then we do a tree wide update of current patterns which are
present. As evident from log below this pattern is frequent in the
kernel.
This series can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git
topic/pm_runtime_last_busy_and_autosuspend
Fengguang's kbuild has tested it so it shouldn't break things for anyone.
Barring one patch (explictyly mentioned in its changelog) rest are simple
replacements.
If all are okay, this should be merged thru PM tree as it depends on macro
addition.
Subhransu S. Prusty (1):
PM: Add helper pm_runtime_last_busy_and_autosuspend()
Vinod Koul (26):
dmaengine: ste_dma: use pm_runtime_last_busy_and_autosuspend helper
extcon: arizona: use pm_runtime_last_busy_and_autosuspend helper
drm/i915: use pm_runtime_last_busy_and_autosuspend helper
drm/nouveau: use pm_runtime_last_busy_and_autosuspend helper
drm/radeon: use pm_runtime_last_busy_and_autosuspend helper
vga_switcheroo: use pm_runtime_last_busy_and_autosuspend helper
i2c: designware: use pm_runtime_last_busy_and_autosuspend helper
i2c: omap: use pm_runtime_last_busy_and_autosuspend helper
i2c: qup: use pm_runtime_last_busy_and_autosuspend helper
mfd: ab8500-gpadc: use pm_runtime_last_busy_and_autosuspend helper
mfd: arizona: use pm_runtime_last_busy_and_autosuspend helper
mei: use pm_runtime_last_busy_and_autosuspend helper
mmc: use pm_runtime_last_busy_and_autosuspend helper
mmc: mmci: use pm_runtime_last_busy_and_autosuspend helper
mmc: omap_hsmmc: use pm_runtime_last_busy_and_autosuspend helper
mmc: sdhci-pxav3: use pm_runtime_last_busy_and_autosuspend helper
mmc: sdhci: use pm_runtime_last_busy_and_autosuspend helper
NFC: trf7970a: use pm_runtime_last_busy_and_autosuspend helper
pm2301-charger: use pm_runtime_last_busy_and_autosuspend helper
spi: omap2-mcspi: use pm_runtime_last_busy_and_autosuspend helper
spi: orion: use pm_runtime_last_busy_and_autosuspend helper
spi: ti-qspi: use pm_runtime_last_busy_and_autosuspend helper
spi: core: use pm_runtime_last_busy_and_autosuspend helper
tty: serial: omap: use pm_runtime_last_busy_and_autosuspend helper
usb: musb: omap2430: use pm_runtime_last_busy_and_autosuspend helper
video: fbdev: use pm_runtime_last_busy_and_autosuspend helper
Documentation/power/runtime_pm.txt | 4 ++
drivers/dma/ste_dma40.c | 30 ++++---------
drivers/extcon/extcon-arizona.c | 6 +--
drivers/gpu/drm/i915/intel_pm.c | 3 +-
drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +-
drivers/gpu/drm/nouveau/nouveau_drm.c | 9 +---
drivers/gpu/drm/radeon/radeon_connectors.c | 15 ++----
drivers/gpu/drm/radeon/radeon_drv.c | 5 +-
drivers/gpu/drm/radeon/radeon_kms.c | 6 +--
drivers/gpu/vga/vga_switcheroo.c | 7 +--
drivers/i2c/busses/i2c-designware-core.c | 3 +-
drivers/i2c/busses/i2c-omap.c | 6 +--
drivers/i2c/busses/i2c-qup.c | 3 +-
drivers/mfd/ab8500-gpadc.c | 6 +--
drivers/mfd/arizona-irq.c | 3 +-
drivers/misc/mei/client.c | 12 ++----
drivers/mmc/core/core.c | 3 +-
drivers/mmc/host/mmci.c | 12 ++----
drivers/mmc/host/omap_hsmmc.c | 19 ++-------
drivers/mmc/host/sdhci-pxav3.c | 6 +--
drivers/mmc/host/sdhci.c | 3 +-
drivers/nfc/trf7970a.c | 3 +-
drivers/power/pm2301_charger.c | 3 +-
drivers/spi/spi-omap2-mcspi.c | 9 +---
drivers/spi/spi-orion.c | 3 +-
drivers/spi/spi-ti-qspi.c | 5 +-
drivers/spi/spi.c | 6 +--
drivers/tty/serial/omap-serial.c | 60 +++++++++------------------
drivers/usb/musb/omap2430.c | 6 +--
drivers/video/fbdev/auo_k190x.c | 9 +---
include/linux/pm_runtime.h | 6 +++
31 files changed, 97 insertions(+), 177 deletions(-)
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 27/27] video: fbdev: use pm_runtime_last_busy_and_autosuspend helper
2014-09-24 16:26 [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper Vinod Koul
@ 2014-09-24 16:27 ` Vinod Koul
2014-09-24 20:28 ` [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper Rafael J. Wysocki
[not found] ` <20140925142201.GD28045@saruman>
2 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2014-09-24 16:27 UTC (permalink / raw)
To: linux-kernel
Cc: subhransu.s.prusty, vinod.koul, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, Jingoo Han, Laurent Pinchart, Rob Clark,
Daniel Vetter, linux-fbdev
Use the new pm_runtime_last_busy_and_autosuspend helper instead of open
coding the same code
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
drivers/video/fbdev/auo_k190x.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/video/fbdev/auo_k190x.c b/drivers/video/fbdev/auo_k190x.c
index 8d2499d..e12f513 100644
--- a/drivers/video/fbdev/auo_k190x.c
+++ b/drivers/video/fbdev/auo_k190x.c
@@ -354,8 +354,7 @@ static void auok190xfb_dpy_deferred_io(struct fb_info *info,
par->update_partial(par, y1, min((u16) (y1 + h), yres));
out:
- pm_runtime_mark_last_busy(info->device);
- pm_runtime_put_autosuspend(info->device);
+ pm_runtime_last_busy_and_autosuspend(info->device);
}
/*
@@ -591,8 +590,7 @@ static int auok190x_read_temperature(struct auok190xfb_par *par)
mutex_unlock(&(par->io_lock));
- pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ pm_runtime_last_busy_and_autosuspend(dev);
/* sanitize and split of half-degrees for now */
temp = ((data[0] & AUOK190X_VERSION_TEMP_MASK) >> 1);
@@ -630,8 +628,7 @@ static void auok190x_identify(struct auok190xfb_par *par)
par->panel_size_int, par->panel_size_float, par->panel_model,
par->epd_type, par->tcon_version, par->lut_version);
- pm_runtime_mark_last_busy(dev);
- pm_runtime_put_autosuspend(dev);
+ pm_runtime_last_busy_and_autosuspend(dev);
}
/*
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper
2014-09-24 16:26 [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper Vinod Koul
2014-09-24 16:27 ` [PATCH 27/27] video: fbdev: use pm_runtime_last_busy_and_autosuspend helper Vinod Koul
@ 2014-09-24 20:28 ` Rafael J. Wysocki
2014-09-25 7:58 ` Vinod Koul
[not found] ` <20140925142201.GD28045@saruman>
2 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2014-09-24 20:28 UTC (permalink / raw)
To: Vinod Koul
Cc: linux-kernel, subhransu.s.prusty, Alan Stern, Alexandre Courbot,
Andrew Morton, Andy Gross, Baruch Siach, Ben Skeggs,
Bjorn Andersson, Chew, Chiau Ee, Chris Ball, Dan Carpenter,
Daniel Vetter, Dave Airlie, David Herrmann, dmaengine, dri-devel,
Du, Wenkai, Grant Grundler, Ilia Mirkin, intel-gfx,
Ivan T. Ivanov, Jaehoon Chung, Jani Nikula <jani.nikul>
On Wednesday, September 24, 2014 09:44:50 PM Vinod Koul wrote:
> This patch series adds a simple macro pm_runtime_last_busy_and_autosuspend()
> which invokes pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend()
> sequentially. Then we do a tree wide update of current patterns which are
> present. As evident from log below this pattern is frequent in the
> kernel.
>
> This series can be found at
> git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git
> topic/pm_runtime_last_busy_and_autosuspend
>
> Fengguang's kbuild has tested it so it shouldn't break things for anyone.
> Barring one patch (explictyly mentioned in its changelog) rest are simple
> replacements.
>
> If all are okay, this should be merged thru PM tree as it depends on macro
> addition.
>
> Subhransu S. Prusty (1):
> PM: Add helper pm_runtime_last_busy_and_autosuspend()
>
> Vinod Koul (26):
> dmaengine: ste_dma: use pm_runtime_last_busy_and_autosuspend helper
> extcon: arizona: use pm_runtime_last_busy_and_autosuspend helper
> drm/i915: use pm_runtime_last_busy_and_autosuspend helper
> drm/nouveau: use pm_runtime_last_busy_and_autosuspend helper
> drm/radeon: use pm_runtime_last_busy_and_autosuspend helper
> vga_switcheroo: use pm_runtime_last_busy_and_autosuspend helper
> i2c: designware: use pm_runtime_last_busy_and_autosuspend helper
> i2c: omap: use pm_runtime_last_busy_and_autosuspend helper
> i2c: qup: use pm_runtime_last_busy_and_autosuspend helper
> mfd: ab8500-gpadc: use pm_runtime_last_busy_and_autosuspend helper
> mfd: arizona: use pm_runtime_last_busy_and_autosuspend helper
> mei: use pm_runtime_last_busy_and_autosuspend helper
> mmc: use pm_runtime_last_busy_and_autosuspend helper
> mmc: mmci: use pm_runtime_last_busy_and_autosuspend helper
> mmc: omap_hsmmc: use pm_runtime_last_busy_and_autosuspend helper
> mmc: sdhci-pxav3: use pm_runtime_last_busy_and_autosuspend helper
> mmc: sdhci: use pm_runtime_last_busy_and_autosuspend helper
> NFC: trf7970a: use pm_runtime_last_busy_and_autosuspend helper
> pm2301-charger: use pm_runtime_last_busy_and_autosuspend helper
> spi: omap2-mcspi: use pm_runtime_last_busy_and_autosuspend helper
> spi: orion: use pm_runtime_last_busy_and_autosuspend helper
> spi: ti-qspi: use pm_runtime_last_busy_and_autosuspend helper
> spi: core: use pm_runtime_last_busy_and_autosuspend helper
> tty: serial: omap: use pm_runtime_last_busy_and_autosuspend helper
> usb: musb: omap2430: use pm_runtime_last_busy_and_autosuspend helper
> video: fbdev: use pm_runtime_last_busy_and_autosuspend helper
>
> Documentation/power/runtime_pm.txt | 4 ++
> drivers/dma/ste_dma40.c | 30 ++++---------
> drivers/extcon/extcon-arizona.c | 6 +--
> drivers/gpu/drm/i915/intel_pm.c | 3 +-
> drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +-
> drivers/gpu/drm/nouveau/nouveau_drm.c | 9 +---
> drivers/gpu/drm/radeon/radeon_connectors.c | 15 ++----
> drivers/gpu/drm/radeon/radeon_drv.c | 5 +-
> drivers/gpu/drm/radeon/radeon_kms.c | 6 +--
> drivers/gpu/vga/vga_switcheroo.c | 7 +--
> drivers/i2c/busses/i2c-designware-core.c | 3 +-
> drivers/i2c/busses/i2c-omap.c | 6 +--
> drivers/i2c/busses/i2c-qup.c | 3 +-
> drivers/mfd/ab8500-gpadc.c | 6 +--
> drivers/mfd/arizona-irq.c | 3 +-
> drivers/misc/mei/client.c | 12 ++----
> drivers/mmc/core/core.c | 3 +-
> drivers/mmc/host/mmci.c | 12 ++----
> drivers/mmc/host/omap_hsmmc.c | 19 ++-------
> drivers/mmc/host/sdhci-pxav3.c | 6 +--
> drivers/mmc/host/sdhci.c | 3 +-
> drivers/nfc/trf7970a.c | 3 +-
> drivers/power/pm2301_charger.c | 3 +-
> drivers/spi/spi-omap2-mcspi.c | 9 +---
> drivers/spi/spi-orion.c | 3 +-
> drivers/spi/spi-ti-qspi.c | 5 +-
> drivers/spi/spi.c | 6 +--
> drivers/tty/serial/omap-serial.c | 60 +++++++++------------------
> drivers/usb/musb/omap2430.c | 6 +--
> drivers/video/fbdev/auo_k190x.c | 9 +---
> include/linux/pm_runtime.h | 6 +++
> 31 files changed, 97 insertions(+), 177 deletions(-)
OK, I guess this is as good as it gets.
What tree would you like it go through?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper
2014-09-24 20:28 ` [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper Rafael J. Wysocki
@ 2014-09-25 7:58 ` Vinod Koul
0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2014-09-25 7:58 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-wireless, Baruch Siach, patches, linux-doc, Seungwon Jeon,
Daniel Vetter, Chris Ball, dri-devel, Marcin Wojtas,
Rafael J. Wysocki, Laurent Pinchart, David Herrmann,
Shinya Kuribayashi, Laurent Pinchart, Jingoo Han, Jaehoon Chung,
Jani Nikula, Tomi Valkeinen, Alan Stern, Ben Skeggs,
Bjorn Andersson, Wolfram Sang, Dave Airlie
On Wed, Sep 24, 2014 at 10:28:07PM +0200, Rafael J. Wysocki wrote:
>
> OK, I guess this is as good as it gets.
>
> What tree would you like it go through?
Since rest of the patches are dependent upon 1st patch which should go thru
your tree, we should merge this thru your tree
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper
[not found] ` <20140925142758.GB1316@katana>
@ 2014-09-25 19:54 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2014-09-25 19:54 UTC (permalink / raw)
To: Wolfram Sang, Vinod Koul
Cc: linux-wireless, Baruch Siach, patches, linux-doc, Seungwon Jeon,
Daniel Vetter, Chris Ball, dri-devel, Marcin Wojtas,
Rafael J. Wysocki, Laurent Pinchart, David Herrmann,
Shinya Kuribayashi, Laurent Pinchart, Jingoo Han, Jaehoon Chung,
Jani Nikula, Tomi Valkeinen, Alan Stern, Ben Skeggs,
Bjorn Andersson, Dave Airlie, Ulf Hansson <ulf.hanss>
On Thursday, September 25, 2014 04:27:58 PM Wolfram Sang wrote:
>
> --Bn2rw/3z4jIqBvZU
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Thu, Sep 25, 2014 at 09:22:01AM -0500, Felipe Balbi wrote:
> > On Thu, Sep 25, 2014 at 01:27:18PM +0530, Vinod Koul wrote:
> > > On Wed, Sep 24, 2014 at 03:32:19PM -0500, Felipe Balbi wrote:
> > > > > > > OK, I guess this is as good as it gets.
> > > > > > >
> > > > > > > What tree would you like it go through?
> > > > > >
> > > > > > Do we really need this new helper ? I mean, the very moment when > we
> > > > > > decide to implement ->runtime_idle() we will need to get rid of t> his
> > > > > > change. I wonder if it's really valid...
> > > > >
> > > > > I'm not sure I'm following? This seems to simply implement what dr> ivers
> > > > > have been doing already as one function. Why would it be invalid t> o reduce
> > > > > code duplication?
> > > >
> > > > For two reasons:
> > > >
> > > > 1) the helper has no inteligence whatsoever. It just calls the same
> > > > functions.
> > > >
> > > > 2) the duplication will vanish whenever someone implements
> > > > ->runtime_idle() and have that call pm_runtime_autosuspend() (like PCI
> > > > and USB buses are doing today). This will just be yet another line th> at
> > > > needs to change.
> > > >
> > > > Frankly though, no strong feelings, I just think it's a commit that
> > > > doesn't bring that any benefits other than looking like one line was
> > > > removed.
> > > and yes that is what it tries to do nothing more nothing less. If in fu> ture
> > > there are no users (today we have quite a few), then we can remove the > dead
> > > macro, no harm. But that is not the situation today.
> >
> > as I said, a commit that's bound to be useless. It's not like you're
> > saving 10 lines of code, it's only one. Replacing two simple lines with
> > a function which takes <joke> almost as many characters to type </joke>.
> >
> > IMO, this is pretty useless and I'd rather not see them in the drivers I
> > maintain, sorry.
>
> It is not a NACK from me; yet from a high-level perspective I agree with
> Felipe.
OK
I'd rather not merge something that driver people don't want to use.
Vinod?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-25 19:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-24 16:26 [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper Vinod Koul
2014-09-24 16:27 ` [PATCH 27/27] video: fbdev: use pm_runtime_last_busy_and_autosuspend helper Vinod Koul
2014-09-24 20:28 ` [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper Rafael J. Wysocki
2014-09-25 7:58 ` Vinod Koul
[not found] ` <20140925142201.GD28045@saruman>
[not found] ` <20140925142758.GB1316@katana>
2014-09-25 19:54 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).