linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] simplefb: Change simplefb_init from module_init to fs_initcall
Date: Thu, 13 Nov 2014 08:50:09 +0000	[thread overview]
Message-ID: <1415868610-13297-3-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1415868610-13297-1-git-send-email-hdegoede@redhat.com>

One of the reasons for having the simplefb nodes in /chosen, and doing
explicit enumeration of the nodes there, is too allow enumerating them sooner,
so that we get a console earlier on.

Doing this earlier then fs_initcall is not useful, since the fb only turns into
a console when fbcon intializes, which is a fs_initcall too.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/video/fbdev/simplefb.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
index 2705af8..48e292a 100644
--- a/drivers/video/fbdev/simplefb.c
+++ b/drivers/video/fbdev/simplefb.c
@@ -415,7 +415,11 @@ static void __exit simplefb_exit(void)
 	platform_driver_unregister(&simplefb_driver);
 }
 
-module_init(simplefb_init);
+/*
+ * While this can be a module, if builtin it's most likely the console
+ * So let's leave module_exit but move module_init to an earlier place
+ */
+fs_initcall(simplefb_init);
 module_exit(simplefb_exit);
 
 MODULE_AUTHOR("Stephen Warren <swarren@wwwdotorg.org>");
-- 
2.1.0


  parent reply	other threads:[~2014-11-13  8:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13  8:50 [PATCH v2 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Hans de Goede
2014-11-13  8:50 ` [PATCH v2 2/4] simplefb: Add support for enumerating simplefb dt nodes in /chosen Hans de Goede
2014-11-13 10:27   ` Grant Likely
2014-11-13  8:50 ` Hans de Goede [this message]
2014-11-13  8:50 ` [PATCH v2 4/4] fbcon: Change fbcon_init from module_init to fs_initcall Hans de Goede
2014-11-13 10:45 ` [PATCH v2 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Maxime Ripard
2014-11-13 11:02 ` Grant Likely
2014-11-13 12:03   ` Grant Likely
2014-11-13 12:29     ` Hans de Goede
2014-11-13 12:14   ` Hans de Goede
2014-11-13 12:36     ` Grant Likely
2014-11-13 12:37       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415868610-13297-3-git-send-email-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).