From: Hans de Goede <hdegoede@redhat.com>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/5] of.h: Keep extern declaration of of_* variables when !CONFIG_OF
Date: Fri, 14 Nov 2014 11:03:13 +0000 [thread overview]
Message-ID: <1415962996-31712-2-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1415962996-31712-1-git-send-email-hdegoede@redhat.com>
Keep the extern declaration of of_allnodes and friends, when building without
of support, this way code using them can be written like this:
if (IS_ENABLED(CONFIG_OF_PLATFORM) && of_chosen) {
for_each_child_of_node(of_chosen, np)
...
}
And rely on the compiler optimizing it away, avoiding the need for #ifdef-ery.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
include/linux/of.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/of.h b/include/linux/of.h
index 6545e7a..f83ca9d 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -105,8 +105,6 @@ static inline struct device_node *of_node_get(struct device_node *node)
static inline void of_node_put(struct device_node *node) { }
#endif /* !CONFIG_OF_DYNAMIC */
-#ifdef CONFIG_OF
-
/* Pointer for first entry in chain of all nodes. */
extern struct device_node *of_allnodes;
extern struct device_node *of_chosen;
@@ -114,6 +112,7 @@ extern struct device_node *of_aliases;
extern struct device_node *of_stdout;
extern raw_spinlock_t devtree_lock;
+#ifdef CONFIG_OF
static inline bool of_have_populated_dt(void)
{
return of_allnodes != NULL;
--
2.1.0
next prev parent reply other threads:[~2014-11-14 11:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 11:03 [PATCH v5 1/5] dt-bindings: simplefb: Specify node location and handoff related properties Hans de Goede
2014-11-14 11:03 ` Hans de Goede [this message]
2014-11-14 11:03 ` [PATCH v5 3/5] simplefb: Add support for enumerating simplefb dt nodes in /chosen Hans de Goede
2014-11-14 11:03 ` [PATCH v5 4/5] fbcon: Change fbcon_init from module_init to fs_initcall Hans de Goede
2014-11-14 11:03 ` [PATCH v5 5/5] simplefb: Change simplefb_init " Hans de Goede
2014-11-14 14:24 ` [PATCH v5 1/5] dt-bindings: simplefb: Specify node location and handoff related properties Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415962996-31712-2-git-send-email-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).