From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Date: Thu, 18 Dec 2014 13:39:38 +0000 Subject: Re: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c Message-Id: <1418909978.2236.0.camel@pengutronix.de> List-Id: References: <54920A54.2060608@gmail.com> <5492ABE7.1060900@samsung.com> <5492D80E.3010906@gmail.com> In-Reply-To: <5492D80E.3010906@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Am Donnerstag, den 18.12.2014, 08:35 -0500 schrieb nick: > Krzysztof, > If we look at the code for this function, it already is handling the data correctly. In addition the locks > seem to be better protection then msleep. Further more is no reason for this delay as we are neither resetting > the hardware or waiting for the hardware here so why is it needed? I don't have Exynos based hardware lying > around through to test it. If you can't test it, don't touch it. It's that simple. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |