linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Longerbeam <slongerbeam@gmail.com>
To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-fbdev@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Shawn Guo <shawn.guo@linaro.org>,
	Denis Carikli <denis@eukrea.com>,
	Jiada Wang <jiada_wang@mentor.com>,
	Deepak Das <deepak_das@mentor.com>,
	Steve Longerbeam <steve_longerbeam@mentor.com>
Subject: [PATCH v2 1/7] gpu: ipu-di: Add ipu_di_adjust_videomode()
Date: Fri, 19 Dec 2014 02:00:20 +0000	[thread overview]
Message-ID: <1418954426-21909-2-git-send-email-steve_longerbeam@mentor.com> (raw)
In-Reply-To: <1418954426-21909-1-git-send-email-steve_longerbeam@mentor.com>

From: Jiada Wang <jiada_wang@mentor.com>

On some monitors, high resolution modes are not working, exhibiting
pixel column truncation problems (for example, 1280x1024 displays as
1280x1022).

The function ipu_di_adjust_videomode() aims to fix these issues by
adjusting a passed videomode to IPU restrictions. The function can
be called from the drm_crtc_helper_funcs->mode_fixup() methods.

Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
Signed-off-by: Deepak Das <deepak_das@mentor.com>
Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
---
 drivers/gpu/ipu-v3/ipu-di.c |   29 +++++++++++++++++++++++++++++
 include/video/imx-ipu-v3.h  |    2 ++
 2 files changed, 31 insertions(+)

diff --git a/drivers/gpu/ipu-v3/ipu-di.c b/drivers/gpu/ipu-v3/ipu-di.c
index c490ba4..46f9570 100644
--- a/drivers/gpu/ipu-v3/ipu-di.c
+++ b/drivers/gpu/ipu-v3/ipu-di.c
@@ -511,6 +511,35 @@ static void ipu_di_config_clock(struct ipu_di *di,
 		clk_get_rate(di->clk_di_pixel) / (clkgen0 >> 4));
 }
 
+/*
+ * This function is called to adjust a video mode to IPU restrictions.
+ * It is meant to be called from drm crtc mode_fixup() methods.
+ */
+int ipu_di_adjust_videomode(struct ipu_di *di, struct videomode *mode)
+{
+	u32 diff;
+
+	if (mode->vfront_porch >= 2)
+		return 0;
+
+	diff = 2 - mode->vfront_porch;
+
+	if (mode->vback_porch >= diff) {
+		mode->vfront_porch = 2;
+		mode->vback_porch -= diff;
+	} else if (mode->vsync_len > diff) {
+		mode->vfront_porch = 2;
+		mode->vsync_len = mode->vsync_len - diff;
+	} else {
+		dev_warn(di->ipu->dev, "failed to adjust videomode\n");
+		return -EINVAL;
+	}
+
+	dev_warn(di->ipu->dev, "videomode adapted for IPU restrictions\n");
+	return 0;
+}
+EXPORT_SYMBOL_GPL(ipu_di_adjust_videomode);
+
 int ipu_di_init_sync_panel(struct ipu_di *di, struct ipu_di_signal_cfg *sig)
 {
 	u32 reg;
diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h
index c74bf4a..d333d54 100644
--- a/include/video/imx-ipu-v3.h
+++ b/include/video/imx-ipu-v3.h
@@ -17,6 +17,7 @@
 #include <linux/bitmap.h>
 #include <linux/fb.h>
 #include <media/v4l2-mediabus.h>
+#include <video/videomode.h>
 
 struct ipu_soc;
 
@@ -236,6 +237,7 @@ void ipu_di_put(struct ipu_di *);
 int ipu_di_disable(struct ipu_di *);
 int ipu_di_enable(struct ipu_di *);
 int ipu_di_get_num(struct ipu_di *);
+int ipu_di_adjust_videomode(struct ipu_di *di, struct videomode *mode);
 int ipu_di_init_sync_panel(struct ipu_di *, struct ipu_di_signal_cfg *sig);
 
 /*
-- 
1.7.9.5


  reply	other threads:[~2014-12-19  2:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19  2:00 [PATCH v2 0/7] imx-drm: ipuv3-crtc: Implement mode_fixup Steve Longerbeam
2014-12-19  2:00 ` Steve Longerbeam [this message]
2014-12-19 11:07   ` [PATCH v2 1/7] gpu: ipu-di: Add ipu_di_adjust_videomode() Philipp Zabel
2014-12-19  2:00 ` [PATCH v2 2/7] gpu: ipu-di: remove some non-functional code Steve Longerbeam
2014-12-19  2:00 ` [PATCH v2 3/7] drm_modes: add videomode_from_drm_display_mode Steve Longerbeam
2014-12-19 11:03   ` Philipp Zabel
2014-12-19 19:03     ` Emil Velikov
2014-12-19 19:10     ` Steve Longerbeam
2014-12-19  2:00 ` [PATCH v2 4/7] imx-drm: ipuv3-crtc: Implement mode_fixup Steve Longerbeam
2014-12-20 15:52   ` Russell King - ARM Linux
2014-12-22 15:53     ` Philipp Zabel
2014-12-19  2:00 ` [PATCH v2 5/7] imx-drm: encoder prepare/mode_set must use adjusted mode Steve Longerbeam
2014-12-19  2:00 ` [PATCH v2 6/7] gpu: ipu-v3: Use videomode in struct ipu_di_signal_cfg Steve Longerbeam
2014-12-19  2:00 ` [PATCH v2 7/7] gpu: ipu-di: Switch to DIV_ROUND_CLOSEST for DI clock divider calc Steve Longerbeam
2015-01-07 18:27 ` [PATCH v2 0/7] imx-drm: ipuv3-crtc: Implement mode_fixup Philipp Zabel
2015-01-23  2:56   ` Liu Ying
2015-01-23 10:50     ` Philipp Zabel
2015-01-23 14:44       ` Fabio Estevam
2015-01-23 15:06     ` Fabio Estevam
2015-01-23 16:18       ` Philipp Zabel
2015-01-23 16:27         ` Fabio Estevam
2015-01-23 16:39           ` Philipp Zabel
2015-01-23 16:41             ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418954426-21909-2-git-send-email-steve_longerbeam@mentor.com \
    --to=slongerbeam@gmail.com \
    --cc=airlied@linux.ie \
    --cc=deepak_das@mentor.com \
    --cc=denis@eukrea.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@freescale.com \
    --cc=jiada_wang@mentor.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=plagnioj@jcrosoft.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=shawn.guo@linaro.org \
    --cc=steve_longerbeam@mentor.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).