From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: LFBDEV <linux-fbdev@vger.kernel.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Subject: [PATCH 2/2] fbdev: ssd1307fb: check return value while setting offset
Date: Thu, 08 Jan 2015 08:17:59 +0000 [thread overview]
Message-ID: <1420705079-3741-3-git-send-email-prabhakar.csengg@gmail.com> (raw)
In-Reply-To: <1420705079-3741-1-git-send-email-prabhakar.csengg@gmail.com>
this patch checks the return value of write command while
setting the display offset.
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/video/fbdev/ssd1307fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 70e3ce8..a7ecaa6 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -342,7 +342,7 @@ static int ssd1307fb_ssd1306_init(struct ssd1307fb_par *par)
/* set display offset value */
ret = ssd1307fb_write_cmd(par->client, SSD1307FB_SET_DISPLAY_OFFSET);
- ret = ssd1307fb_write_cmd(par->client, 0x20);
+ ret = ret & ssd1307fb_write_cmd(par->client, 0x20);
if (ret < 0)
return ret;
--
1.9.1
next prev parent reply other threads:[~2015-01-08 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 8:17 [PATCH 0/2] fbdev: ssd1307fb: fixes Lad, Prabhakar
2015-01-08 8:17 ` [PATCH 1/2] fbdev: ssd1307fb: set default height if not found in DT node Lad, Prabhakar
2015-01-08 9:31 ` Maxime Ripard
2015-01-15 11:27 ` Tomi Valkeinen
2015-01-08 8:17 ` Lad, Prabhakar [this message]
2015-01-08 9:32 ` [PATCH 2/2] fbdev: ssd1307fb: check return value while setting offset Maxime Ripard
2015-01-13 11:43 ` Tomi Valkeinen
2015-01-13 11:53 ` Prabhakar Lad
2015-01-13 13:39 ` Maxime Ripard
2015-01-13 13:46 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420705079-3741-3-git-send-email-prabhakar.csengg@gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).