* [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write_data()
@ 2015-01-12 19:21 Lad, Prabhakar
2015-01-13 13:43 ` Maxime Ripard
2015-01-15 11:26 ` Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Lad, Prabhakar @ 2015-01-12 19:21 UTC (permalink / raw)
To: LFBDEV, Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
Maxime Ripard
Cc: LKML, Lad, Prabhakar
this patch drops the unused function ssd1307fb_write_data().
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/video/fbdev/ssd1307fb.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index a7ecaa6..c891f11 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -122,23 +122,6 @@ static inline int ssd1307fb_write_cmd(struct i2c_client *client, u8 cmd)
return ret;
}
-static inline int ssd1307fb_write_data(struct i2c_client *client, u8 data)
-{
- struct ssd1307fb_array *array;
- int ret;
-
- array = ssd1307fb_alloc_array(1, SSD1307FB_DATA);
- if (!array)
- return -ENOMEM;
-
- array->data[0] = data;
-
- ret = ssd1307fb_write_array(client, array, 1);
- kfree(array);
-
- return ret;
-}
-
static void ssd1307fb_update_display(struct ssd1307fb_par *par)
{
struct ssd1307fb_array *array;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write_data()
2015-01-12 19:21 [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write_data() Lad, Prabhakar
@ 2015-01-13 13:43 ` Maxime Ripard
2015-01-15 11:26 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2015-01-13 13:43 UTC (permalink / raw)
To: Lad, Prabhakar
Cc: LFBDEV, Jean-Christophe Plagniol-Villard, Tomi Valkeinen, LKML
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
On Mon, Jan 12, 2015 at 07:21:14PM +0000, Lad, Prabhakar wrote:
> this patch drops the unused function ssd1307fb_write_data().
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write_data()
2015-01-12 19:21 [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write_data() Lad, Prabhakar
2015-01-13 13:43 ` Maxime Ripard
@ 2015-01-15 11:26 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2015-01-15 11:26 UTC (permalink / raw)
To: Lad, Prabhakar, LFBDEV, Jean-Christophe Plagniol-Villard,
Maxime Ripard
Cc: LKML
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
On 12/01/15 21:21, Lad, Prabhakar wrote:
> this patch drops the unused function ssd1307fb_write_data().
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
> drivers/video/fbdev/ssd1307fb.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index a7ecaa6..c891f11 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -122,23 +122,6 @@ static inline int ssd1307fb_write_cmd(struct i2c_client *client, u8 cmd)
> return ret;
> }
>
> -static inline int ssd1307fb_write_data(struct i2c_client *client, u8 data)
> -{
> - struct ssd1307fb_array *array;
> - int ret;
> -
> - array = ssd1307fb_alloc_array(1, SSD1307FB_DATA);
> - if (!array)
> - return -ENOMEM;
> -
> - array->data[0] = data;
> -
> - ret = ssd1307fb_write_array(client, array, 1);
> - kfree(array);
> -
> - return ret;
> -}
> -
> static void ssd1307fb_update_display(struct ssd1307fb_par *par)
> {
> struct ssd1307fb_array *array;
>
Thanks, queued for 3.20.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-15 11:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-12 19:21 [PATCH] fbdev: ssd1307fb: drop unused function ssd1307fb_write_data() Lad, Prabhakar
2015-01-13 13:43 ` Maxime Ripard
2015-01-15 11:26 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).