linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lstoakes@gmail.com>
To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	gregkh@linuxfoundation.org
Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	Lorenzo Stoakes <lstoakes@gmail.com>
Subject: [PATCH RESEND 2 2/5] staging: sm750fb: Make internal functions static
Date: Fri, 20 Mar 2015 15:22:12 +0000	[thread overview]
Message-ID: <1426864935-29350-2-git-send-email-lstoakes@gmail.com> (raw)
In-Reply-To: <1426864935-29350-1-git-send-email-lstoakes@gmail.com>

This patch declares externally unavailable functions static. This fixes
the following sparse warnings:-

drivers/staging/sm750fb/ddk750_hwi2c.c:63:6: warning: symbol 'hwI2CWaitTXDone' was not declared. Should it be static?
drivers/staging/sm750fb/ddk750_hwi2c.c:93:14: warning: symbol 'hwI2CWriteData' was not declared. Should it be static?
drivers/staging/sm750fb/ddk750_hwi2c.c:160:14: warning: symbol 'hwI2CReadData' was not declared. Should it be static?

Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
---
 drivers/staging/sm750fb/ddk750_hwi2c.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c
index 84dfb6f..7826376 100644
--- a/drivers/staging/sm750fb/ddk750_hwi2c.c
+++ b/drivers/staging/sm750fb/ddk750_hwi2c.c
@@ -60,7 +60,7 @@ void hwI2CClose(void)
 }


-long hwI2CWaitTXDone(void)
+static long hwI2CWaitTXDone(void)
 {
     unsigned int timeout;

@@ -90,7 +90,7 @@ long hwI2CWaitTXDone(void)
  *  Return Value:
  *      Total number of bytes those are actually written.
  */
-unsigned int hwI2CWriteData(
+static unsigned int hwI2CWriteData(
     unsigned char deviceAddress,
     unsigned int length,
     unsigned char *pBuffer
@@ -157,7 +157,7 @@ unsigned int hwI2CWriteData(
  *  Return Value:
  *      Total number of actual bytes read from the slave device
  */
-unsigned int hwI2CReadData(
+static unsigned int hwI2CReadData(
     unsigned char deviceAddress,
     unsigned int length,
     unsigned char *pBuffer
--
2.3.2

  reply	other threads:[~2015-03-20 15:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 15:22 [PATCH RESEND 2 1/5] staging: sm750fb: Use memset_io instead of memset Lorenzo Stoakes
2015-03-20 15:22 ` Lorenzo Stoakes [this message]
2015-03-20 15:22 ` [PATCH RESEND 2 3/5] staging: sm750fb: Remove unused function Lorenzo Stoakes
2015-03-20 15:22 ` [PATCH RESEND 2 4/5] staging: sm750fb: Fix __iomem pointer types Lorenzo Stoakes
2015-03-20 15:22 ` [PATCH RESEND 2 5/5] staging: sm750fb: Remove spinlock helper function Lorenzo Stoakes
2015-03-23 10:53 ` [PATCH RESEND 2 1/5] staging: sm750fb: Use memset_io instead of memset Dan Carpenter
2015-03-23 11:14   ` Lorenzo Stoakes
2015-03-23 11:51     ` Dan Carpenter
2015-03-23 12:43       ` Lorenzo Stoakes
2015-03-23 12:55         ` Sudip Mukherjee
2015-03-23 13:02           ` Lorenzo Stoakes
2015-03-23 13:26             ` Sudip Mukherjee
2015-03-23 13:16               ` Lorenzo Stoakes
2015-03-23 13:21                 ` Lorenzo Stoakes
2015-03-23 13:25                   ` Lorenzo Stoakes
2015-03-23 13:55                     ` Sudip Mukherjee
2015-03-23 13:55 ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426864935-29350-2-git-send-email-lstoakes@gmail.com \
    --to=lstoakes@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).