linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH v2 3/9] staging: sm7xxfb: add newline
Date: Wed, 17 Jun 2015 11:36:42 +0000	[thread overview]
Message-ID: <1434540288-8289-4-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1434540288-8289-1-git-send-email-sudipm.mukherjee@gmail.com>

new line was missing in some of the dev_* macros while printing
the debug and error messages.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/staging/sm7xxfb/sm7xxfb.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 5667fbf..f18fef9 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -741,7 +741,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
 	int err;
 	unsigned long mmio_base;
 
-	dev_info(&pdev->dev, "Silicon Motion display driver.");
+	dev_info(&pdev->dev, "Silicon Motion display driver.\n");
 
 	err = pci_enable_device(pdev);	/* enable SMTC chip */
 	if (err)
@@ -815,12 +815,12 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
 #ifdef __BIG_ENDIAN
 		if (sfb->fb->var.bits_per_pixel = 32) {
 			sfb->lfb += 0x800000;
-			dev_info(&pdev->dev, "sfb->lfb=%p", sfb->lfb);
+			dev_info(&pdev->dev, "sfb->lfb=%p\n", sfb->lfb);
 		}
 #endif
 		if (!smtc_regbaseaddress) {
 			dev_err(&pdev->dev,
-				"%s: unable to map memory mapped IO!",
+				"%s: unable to map memory mapped IO!\n",
 				sfb->fb->fix.id);
 			err = -ENOMEM;
 			goto failed_fb;
@@ -854,7 +854,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
 		break;
 	default:
 		dev_err(&pdev->dev,
-			"No valid Silicon Motion display chip was detected!");
+			"No valid Silicon Motion display chip was detected!\n");
 
 		goto failed_fb;
 	}
@@ -876,14 +876,14 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
 		goto failed;
 
 	dev_info(&pdev->dev,
-		 "Silicon Motion SM%X Rev%X primary display mode %dx%d-%d Init Complete.",
+		 "Silicon Motion SM%X Rev%X primary display mode %dx%d-%d Init Complete.\n",
 		 sfb->chip_id, sfb->chip_rev_id, sfb->fb->var.xres,
 		 sfb->fb->var.yres, sfb->fb->var.bits_per_pixel);
 
 	return 0;
 
 failed:
-	dev_err(&pdev->dev, "Silicon Motion, Inc. primary display init fail.");
+	dev_err(&pdev->dev, "Silicon Motion, Inc. primary display init fail.\n");
 
 	smtc_unmap_smem(sfb);
 	smtc_unmap_mmio(sfb);
-- 
1.8.1.2


  parent reply	other threads:[~2015-06-17 11:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 11:36 [PATCH v2 0/9] fix sm7xxfb Sudip Mukherjee
2015-06-17 11:36 ` [PATCH v2 1/9] staging: sm7xxfb: declare struct as const Sudip Mukherjee
2015-06-17 11:36 ` [PATCH v2 2/9] staging: sm7xxfb: remove numvgamodes Sudip Mukherjee
2015-06-17 11:36 ` Sudip Mukherjee [this message]
2015-06-17 11:36 ` [PATCH v2 4/9] staging: sm7xxfb: no space after cast Sudip Mukherjee
2015-06-17 11:36 ` [PATCH v2 5/9] staging: sm7xxfb: fix alignment Sudip Mukherjee
2015-06-19 14:45   ` Dan Carpenter
2015-06-17 11:36 ` [PATCH v2 6/9] staging: sm7xxfb: reduce indention Sudip Mukherjee
2015-06-17 11:36 ` [PATCH v2 7/9] staging: sm7xxfb: move mode table Sudip Mukherjee
2015-06-19 14:48   ` Dan Carpenter
2015-06-17 11:36 ` [PATCH v2 8/9] staging: sm7xxfb: fix indention Sudip Mukherjee
2015-06-19 14:50   ` Dan Carpenter
2015-06-17 11:36 ` [PATCH v2 9/9] staging: sm7xxfb: fix camelcase Sudip Mukherjee
2015-06-19 14:51   ` Dan Carpenter
2015-06-18  4:43 ` [PATCH v2 0/9] fix sm7xxfb Greg Kroah-Hartman
2015-06-18  4:45   ` Greg Kroah-Hartman
2015-06-18  8:49     ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434540288-8289-4-git-send-email-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).