From: Marcin Chojnacki <marcinch7@gmail.com>
To: plagnioj@jcrosoft.com
Cc: tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Marcin Chojnacki <marcinch7@gmail.com>
Subject: [PATCH] fbdev: remove unnecessary memset in vfb
Date: Thu, 18 Jun 2015 13:01:52 +0000 [thread overview]
Message-ID: <1434632512-128161-1-git-send-email-marcinch7@gmail.com> (raw)
In vfb_probe memory is allocated using rvmalloc which automatically
sets the allocated memory to zero. This patch removes the second
unnecessary memset in vfb_probe.
Signed-off-by: Marcin Chojnacki <marcinch7@gmail.com>
---
drivers/video/fbdev/vfb.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/video/fbdev/vfb.c b/drivers/video/fbdev/vfb.c
index 70a897b..b2d38b7 100644
--- a/drivers/video/fbdev/vfb.c
+++ b/drivers/video/fbdev/vfb.c
@@ -490,14 +490,6 @@ static int vfb_probe(struct platform_device *dev)
if (!(videomemory = rvmalloc(videomemorysize)))
return retval;
- /*
- * VFB must clear memory to prevent kernel info
- * leakage into userspace
- * VGA-based drivers MUST NOT clear memory if
- * they want to be able to take over vgacon
- */
- memset(videomemory, 0, videomemorysize);
-
info = framebuffer_alloc(sizeof(u32) * 256, &dev->dev);
if (!info)
goto err;
--
2.1.4
next reply other threads:[~2015-06-18 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 13:01 Marcin Chojnacki [this message]
2015-08-20 7:56 ` [PATCH] fbdev: remove unnecessary memset in vfb Tomi Valkeinen
2015-08-20 8:21 ` Geert Uytterhoeven
2015-08-20 9:05 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434632512-128161-1-git-send-email-marcinch7@gmail.com \
--to=marcinch7@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).