From: Anatoly Stepanov <drivengroove@gmail.com>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH 09/11] staging: sm750fb: remove assignment from if condition
Date: Sun, 28 Jun 2015 23:44:02 +0000 [thread overview]
Message-ID: <1435535044-22042-10-git-send-email-drivengroove@gmail.com> (raw)
Remove assignment from if condition according to checkpatch.pl message:
"ERROR: do not use assignment in if condition"
Signed-off-by: Anatoly Stepanov <drivengroove@gmail.com>
---
drivers/staging/sm750fb/sm750_hw.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index 3093c25..987da9e 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -43,8 +43,8 @@ int hw_sm750_map(struct lynx_share *share, struct pci_dev *pdev)
* in lynxfb_remove, or memory will not be mapped again
* successfully
* */
-
- if ((ret = pci_request_region(pdev, 1, "sm750fb"))) {
+ ret = pci_request_region(pdev, 1, "sm750fb");
+ if (ret) {
pr_err("Can not request PCI regions.\n");
goto exit;
}
@@ -77,7 +77,8 @@ int hw_sm750_map(struct lynx_share *share, struct pci_dev *pdev)
/* reserve the vidmem space of smi adaptor */
#if 0
- if ((ret = pci_request_region(pdev, 0, _moduleName_))) {
+ ret = pci_request_region(pdev, 0, _moduleName_);
+ if (ret) {
pr_err("Can not request PCI regions.\n");
goto exit;
}
--
2.1.0
reply other threads:[~2015-06-28 23:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435535044-22042-10-git-send-email-drivengroove@gmail.com \
--to=drivengroove@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox