From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH 3/5] staging: sm7xxfb: use kernel commandline
Date: Tue, 07 Jul 2015 08:26:35 +0000 [thread overview]
Message-ID: <1436256877-10754-4-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1436256877-10754-1-git-send-email-sudipm.mukherjee@gmail.com>
We were only using the kernel commandline to set the mode if this driver
is builtin, but when it is built as a module we were not having any way
to set the mode. Start using commandline even if it is built as a
module.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/staging/sm7xxfb/sm7xxfb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 8fb62af..4dc9d5f 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -1660,14 +1660,12 @@ static struct pci_driver smtcfb_driver = {
static int __init sm712fb_init(void)
{
-#ifndef MODULE
char *option = NULL;
if (fb_get_options("sm712fb", &option))
return -ENODEV;
if (option && *option)
mode_option = option;
-#endif
sm7xx_vga_setup(mode_option);
return pci_register_driver(&smtcfb_driver);
--
1.8.1.2
next prev parent reply other threads:[~2015-07-07 8:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 8:26 [PATCH 0/5] staging: sm7xxfb: few changes Sudip Mukherjee
2015-07-07 8:26 ` [PATCH 1/5] staging: sm7xxfb: remove unused macros Sudip Mukherjee
2015-07-07 8:26 ` [PATCH 2/5] staging: sm7xxfb: fix error handling Sudip Mukherjee
2015-07-07 8:26 ` Sudip Mukherjee [this message]
2015-07-15 3:06 ` [PATCH 3/5] staging: sm7xxfb: use kernel commandline Greg Kroah-Hartman
2015-07-07 8:26 ` [PATCH 4/5] staging: sm7xxfb: define new macros Sudip Mukherjee
2015-07-15 3:05 ` Greg Kroah-Hartman
2015-07-15 4:58 ` Sudip Mukherjee
2015-07-07 8:26 ` [PATCH 5/5] staging: sm7xxfb: usr fb_read and fb_write Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436256877-10754-4-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).