linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinay Simha BN <simhavcs@gmail.com>
Cc: Vinay Simha BN <simhavcs@gmail.com>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Teddy Wang <teddy.wang@siliconmotion.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER"
	<linux-fbdev@vger.kernel.org>,
	"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] sm750fb: coding style fixes lines over 80 chars - v2
Date: Tue, 21 Jul 2015 07:52:01 +0000	[thread overview]
Message-ID: <1437464402-18451-2-git-send-email-simhavcs@gmail.com> (raw)
In-Reply-To: <1437464402-18451-1-git-send-email-simhavcs@gmail.com>

---
 drivers/staging/sm750fb/sm750_accel.h | 30 ++++++++++++++++++++----------
 drivers/staging/sm750fb/sm750_help.h  | 23 +----------------------
 2 files changed, 21 insertions(+), 32 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750_accel.h b/drivers/staging/sm750fb/sm750_accel.h
index da067a0..c56fa99 100644
--- a/drivers/staging/sm750fb/sm750_accel.h
+++ b/drivers/staging/sm750fb/sm750_accel.h
@@ -259,12 +259,18 @@ unsigned int height, /* width and height of rectangle in pixel value */
 unsigned int rop2);
 
 int hw_imageblit(struct lynx_accel *accel,
-		 const char *pSrcbuf, /* pointer to start of source
-					buffer in system memory */
-		 u32 srcDelta, /* Pitch value (in bytes) of the source buffer,
-				+ive means top down and -ive mean button up */
-		 u32 startBit, /* Mono data can start at any bit in a byte,
-				 this value should be 0 to 7 */
+		 const char *pSrcbuf,  /*
+					* pointer to start of source
+					* buffer in system memory
+					*/
+		 u32 srcDelta, /*
+				* Pitch value (in bytes) of the source buffer,
+				* +ive means top down and -ive mean button up
+				*/
+		 u32 startBit, /*
+				* Mono data can start at any bit in a byte,
+				* this value should be 0 to 7
+				*/
 		 u32 dBase, /* Address of destination: offset in frame buffer */
 		 u32 dPitch,   /* Pitch value of destination surface in BYTE */
 		 u32 bytePerPixel,      /* Color depth of destination surface */
@@ -272,9 +278,13 @@ int hw_imageblit(struct lynx_accel *accel,
 		 u32 dy,       /* Starting coordinate of destination surface */
 		 u32 width,
 		 u32 height,   /* width and height of rectange in pixel value */
-		 u32 fColor,   /* Foreground color (corresponding to a 1 in the
-				 monochrome data */
-		 u32 bColor,   /* Background color (corresponding to a 0 in the
-				 monochrome data */
+		 u32 fColor,   /*
+				* Foreground color (corresponding to a 1 in the
+				* monochrome data
+				*/
+		 u32 bColor,   /*
+				* Background color (corresponding to a 0 in the
+				* monochrome data
+				*/
 		 u32 rop2);
 #endif
diff --git a/drivers/staging/sm750fb/sm750_help.h b/drivers/staging/sm750fb/sm750_help.h
index 43d700b..c9378e2 100644
--- a/drivers/staging/sm750fb/sm750_help.h
+++ b/drivers/staging/sm750fb/sm750_help.h
@@ -1,7 +1,7 @@
 #ifndef LYNX_HELP_H__
 #define LYNX_HELP_H__
 
-/*  FIELD MACROS */
+/* FIELD MACROS */
 #define _LSB(f)             (0 ? f)
 #define _MSB(f)             (1 ? f)
 #define _COUNT(f)           (_MSB(f) - _LSB(f) + 1)
@@ -46,27 +46,6 @@
 	~ _F_MASK(reg ## _ ## field) \
 )
 
-/* Field Macros */
-#define FIELD_START(field)              (0 ? field)
-#define FIELD_END(field)                (1 ? field)
-#define FIELD_SIZE(field)               (1 + FIELD_END(field) - \
-						FIELD_START(field))
-#define FIELD_MASK(field)               (((1 << (FIELD_SIZE(field)-1)) \
-					| ((1 << (FIELD_SIZE(field)-1)) - 1)) \
-					<< FIELD_START(field))
-#define FIELD_NORMALIZE(reg, field)     (((reg) & FIELD_MASK(field)) >> \
-					FIELD_START(field))
-#define FIELD_DENORMALIZE(field, value) (((value) << FIELD_START(field)) & \
-					 FIELD_MASK(field))
-
-#define FIELD_INIT(reg, field, value)   FIELD_DENORMALIZE(reg ## _ ## field, \
-					  reg ## _ ## field ## _ ## value)
-#define FIELD_INIT_VAL(reg, field, value) \
-	(FIELD_DENORMALIZE(reg ## _ ## field, value))
-#define FIELD_VAL_SET(x, r, f, v)       x = x & ~FIELD_MASK(r ## _ ## f) \
-					| FIELD_DENORMALIZE(r ## _ ## f, \
-					 r ## _ ## f ## _ ## v)
-
 #define RGB(r, g, b) \
 ( \
 	(unsigned long) (((r) << 16) | ((g) << 8) | (b)) \
-- 
2.1.2


  reply	other threads:[~2015-07-21  7:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 18:58 [PATCH] sm750fb: coding style fixes lines over 80 chars Vinay Simha BN
2015-07-16  3:57 ` Joe Perches
2015-07-17  7:28   ` Vinay Simha
2015-07-17  7:40 ` Vinay Simha BN
2015-07-17  7:38   ` Joe Perches
2015-07-21  6:56     ` [PATCH] sm750fb: coding style fixes in _accel.h,__help.h Vinay Simha BN
2015-07-21  7:29       ` Sudip Mukherjee
     [not found]         ` <CAGWqDJ5AkG5PwQOkboZfiC1PzXw0j+x5zwaYn0SWWtiks+OP2A@mail.gmail.com>
2015-07-21  7:43           ` Sudip Mukherjee
2015-07-21  7:52       ` [PATCH 1/2] sm750fb: coding style fixes lines over 80 chars Vinay Simha BN
2015-07-21  7:52         ` Vinay Simha BN [this message]
2015-07-21  8:39           ` [PATCH 2/2] sm750fb: coding style fixes lines over 80 chars - v2 Dan Carpenter
2015-07-21  8:14         ` [PATCH 1/2] sm750fb: coding style fixes lines over 80 chars Joe Perches
2015-07-21  8:35         ` Dan Carpenter
     [not found]     ` <CAGWqDJ4dgrsYAiWXMKi2j1-kGoFhQ_rZGxuDuqpbfTG2P7bnsw@mail.gmail.com>
2015-07-27  5:36       ` [PATCH] " Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437464402-18451-2-git-send-email-simhavcs@gmail.com \
    --to=simhavcs@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).