[PATCH] fbdev: select versatile helpers for the integrator

[PATCH] fbdev: select versatile helpers for the integrator

[Linus Walleij]

Commit 11c32d7b6274cb0f554943d65bd4a126c4a86dcd
"video: move Versatile CLCD helpers" missed the fact
that the Integrator/CP is also using the helper, and
as a result the platform got only stubs and no graphics.
Add this as a default selection to Kconfig so we have
graphics again.

Fixes: 11c32d7b6274 (video: move Versatile CLCD helpers)
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/video/fbdev/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 2d98de535e0f..f888561568d9 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -298,7 +298,7 @@ config FB_ARMCLCD
 
 # Helper logic selected only by the ARM Versatile platform family.
 config PLAT_VERSATILE_CLCD
-	def_bool ARCH_VERSATILE || ARCH_REALVIEW || ARCH_VEXPRESS
+	def_bool ARCH_VERSATILE || ARCH_REALVIEW || ARCH_VEXPRESS || ARCH_INTEGRATOR
 	depends on ARM
 	depends on FB_ARMCLCD && FB=y
 
-- 
2.4.3

Re: [PATCH] fbdev: select versatile helpers for the integrator

[Linus Walleij]

On Tue, Jul 28, 2015 at 3:31 PM, Linus Walleij <linus.walleij@linaro.org> wrote:

> Commit 11c32d7b6274cb0f554943d65bd4a126c4a86dcd
> "video: move Versatile CLCD helpers" missed the fact
> that the Integrator/CP is also using the helper, and
> as a result the platform got only stubs and no graphics.
> Add this as a default selection to Kconfig so we have
> graphics again.
>
> Fixes: 11c32d7b6274 (video: move Versatile CLCD helpers)
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Ping on this.

Shall I take this into ARM SoC instead?

Yours,
Linus Walleij

Re: [PATCH] fbdev: select versatile helpers for the integrator

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]



On 10/08/15 12:03, Linus Walleij wrote:
> On Tue, Jul 28, 2015 at 3:31 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> 
>> Commit 11c32d7b6274cb0f554943d65bd4a126c4a86dcd
>> "video: move Versatile CLCD helpers" missed the fact
>> that the Integrator/CP is also using the helper, and
>> as a result the platform got only stubs and no graphics.
>> Add this as a default selection to Kconfig so we have
>> graphics again.
>>
>> Fixes: 11c32d7b6274 (video: move Versatile CLCD helpers)
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Ping on this.
> 
> Shall I take this into ARM SoC instead?

Sorry, I still haven't gotten into dealing with fbdev related mails
after my vacation...

This is needed for 4.2, right? I can pick this up.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] fbdev: select versatile helpers for the integrator

[Linus Walleij]

On Mon, Aug 10, 2015 at 11:19 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On 10/08/15 12:03, Linus Walleij wrote:
>> On Tue, Jul 28, 2015 at 3:31 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>>
>>> Commit 11c32d7b6274cb0f554943d65bd4a126c4a86dcd
>>> "video: move Versatile CLCD helpers" missed the fact
>>> that the Integrator/CP is also using the helper, and
>>> as a result the platform got only stubs and no graphics.
>>> Add this as a default selection to Kconfig so we have
>>> graphics again.
>>>
>>> Fixes: 11c32d7b6274 (video: move Versatile CLCD helpers)
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> Ping on this.
>>
>> Shall I take this into ARM SoC instead?
>
> Sorry, I still haven't gotten into dealing with fbdev related mails
> after my vacation...
>
> This is needed for 4.2, right? I can pick this up.

In theory, it's not like it's regressing the world. I'm fine with
4.3 at this point of you just keep the Fixes:... tag.

Yours,
Linus Walleij

Re: [PATCH] fbdev: select versatile helpers for the integrator

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]



On 13/08/15 11:59, Linus Walleij wrote:
> On Mon, Aug 10, 2015 at 11:19 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> On 10/08/15 12:03, Linus Walleij wrote:
>>> On Tue, Jul 28, 2015 at 3:31 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>>>
>>>> Commit 11c32d7b6274cb0f554943d65bd4a126c4a86dcd
>>>> "video: move Versatile CLCD helpers" missed the fact
>>>> that the Integrator/CP is also using the helper, and
>>>> as a result the platform got only stubs and no graphics.
>>>> Add this as a default selection to Kconfig so we have
>>>> graphics again.
>>>>
>>>> Fixes: 11c32d7b6274 (video: move Versatile CLCD helpers)
>>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>>
>>> Ping on this.
>>>
>>> Shall I take this into ARM SoC instead?
>>
>> Sorry, I still haven't gotten into dealing with fbdev related mails
>> after my vacation...
>>
>> This is needed for 4.2, right? I can pick this up.
> 
> In theory, it's not like it's regressing the world. I'm fine with
> 4.3 at this point of you just keep the Fixes:... tag.

It's in Linus' tree already.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]