From: Peng Fan <van.freenix@gmail.com>
To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org
Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, van.freenix@gmail.com
Subject: [PATCH] staging: sm750fb: fix sparse warning for lock
Date: Wed, 05 Aug 2015 13:26:44 +0000 [thread overview]
Message-ID: <1438781204-13283-1-git-send-email-van.freenix@gmail.com> (raw)
In-Reply-To: <1425934628-3717-1-git-send-email-lstoakes@gmail.com>
Use __acquire() and __release() in the right place to silence the sparse
lock checking warning.
drivers/staging/sm750fb/sm750.c:177:13: warning: context imbalance in 'lynxfb_ops_fillrect' - different lock contexts for basic block
drivers/staging/sm750fb/sm750.c:243:9: warning: context imbalance in 'lynxfb_ops_copyarea' - different lock contexts for basic block
drivers/staging/sm750fb/sm750.c:247:13: warning: context imbalance in 'lynxfb_ops_imageblit' - different lock contexts for basic block
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/sm750fb/sm750.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 8e201f1..5ba1c06 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -203,6 +203,8 @@ static void lynxfb_ops_fillrect(struct fb_info *info,
*/
if (share->dual)
spin_lock(&share->slock);
+ else
+ __acquire(&share->slock);
share->accel.de_fillrect(&share->accel,
base, pitch, Bpp,
@@ -211,6 +213,8 @@ static void lynxfb_ops_fillrect(struct fb_info *info,
color, rop);
if (share->dual)
spin_unlock(&share->slock);
+ else
+ __release(&share->slock);
}
static void lynxfb_ops_copyarea(struct fb_info *info,
@@ -235,6 +239,8 @@ static void lynxfb_ops_copyarea(struct fb_info *info,
*/
if (share->dual)
spin_lock(&share->slock);
+ else
+ __acquire(&share->slock);
share->accel.de_copyarea(&share->accel,
base, pitch, region->sx, region->sy,
@@ -242,6 +248,8 @@ static void lynxfb_ops_copyarea(struct fb_info *info,
region->width, region->height, HW_ROP2_COPY);
if (share->dual)
spin_unlock(&share->slock);
+ else
+ __release(&share->slock);
}
static void lynxfb_ops_imageblit(struct fb_info *info,
@@ -282,6 +290,8 @@ _do_work:
*/
if (share->dual)
spin_lock(&share->slock);
+ else
+ __acquire(&share->slock);
share->accel.de_imageblit(&share->accel,
image->data, image->width>>3, 0,
@@ -291,6 +301,8 @@ _do_work:
fgcol, bgcol, HW_ROP2_COPY);
if (share->dual)
spin_unlock(&share->slock);
+ else
+ __release(&share->slock);
}
static int lynxfb_ops_pan_display(struct fb_var_screeninfo *var,
--
1.8.4
next prev parent reply other threads:[~2015-08-05 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 20:57 [PATCH] staging: sm750fb: Fix sparse warning Lorenzo Stoakes
2015-03-10 7:00 ` Dan Carpenter
2015-03-10 8:47 ` Lorenzo Stoakes
2015-03-10 8:59 ` Dan Carpenter
2015-03-10 9:14 ` Lorenzo Stoakes
2015-03-10 7:54 ` Sudip Mukherjee
2015-03-10 8:44 ` Lorenzo Stoakes
2015-08-05 13:26 ` Peng Fan [this message]
2015-08-05 19:01 ` [PATCH] staging: sm750fb: fix sparse warning for lock Greg KH
2015-08-05 22:34 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438781204-13283-1-git-send-email-van.freenix@gmail.com \
--to=van.freenix@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).