* [PATCH] ocfb: remove incorrect __iomem annotation
@ 2015-08-17 8:10 Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2015-08-17 8:10 UTC (permalink / raw)
To: linux-fbdev
Make sparse happy:
drivers/video/fbdev/ocfb.c:375:64: sparse: incorrect type in argument 3 (different address spaces)
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/video/fbdev/ocfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/ocfb.c b/drivers/video/fbdev/ocfb.c
index de98196..97f11d2 100644
--- a/drivers/video/fbdev/ocfb.c
+++ b/drivers/video/fbdev/ocfb.c
@@ -62,7 +62,7 @@ struct ocfb_dev {
int little_endian;
/* Physical and virtual addresses of framebuffer */
dma_addr_t fb_phys;
- void __iomem *fb_virt;
+ void *fb_virt;
u32 pseudo_palette[PALETTE_SIZE];
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ocfb: remove incorrect __iomem annotation
@ 2015-09-24 10:54 Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2015-09-24 10:54 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On 17/08/15 11:10, Christoph Hellwig wrote:
> Make sparse happy:
Well, I think someone will anyway be unhappy:
- memset_io() is used to clear fb_virt.
- fb_virt is assigned to fbdev->info.screen_base.
I don't know if it's better or worse to have the __iomem in ocfb.c...
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-24 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-17 8:10 [PATCH] ocfb: remove incorrect __iomem annotation Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2015-09-24 10:54 Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).