* [PATCH 1/5] [resend] gxt4500: enable on non-PPC architectures
2015-08-24 20:15 [PATCH 0/5] [resend] gxt4500: Make usable on x86 and fix some bugs Ondrej Zary
@ 2015-08-24 20:15 ` Ondrej Zary
2015-08-24 20:15 ` [PATCH 2/5] [resend] gxt4500: fix 16bpp 565 mode Ondrej Zary
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Ondrej Zary @ 2015-08-24 20:15 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Tomi Valkeinen, linux-fbdev, Kernel development list
These chips can be present at least on x86 too - Fire GL2 AGP has GXT6000P but
this driver is currently limited to PPC.
Enable it for all architectures and add chip configuration for little-endian.
Tested on x86 with Fire GL2 AGP.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
drivers/video/fbdev/Kconfig | 5 +++--
drivers/video/fbdev/gxt4500.c | 7 +++++++
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 2d98de5..78335bd 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2132,7 +2132,7 @@ config FB_UDL
config FB_IBM_GXT4500
tristate "Framebuffer support for IBM GXT4000P/4500P/6000P/6500P adaptors"
- depends on FB && PPC
+ depends on FB
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
@@ -2140,7 +2140,8 @@ config FB_IBM_GXT4500
Say Y here to enable support for the IBM GXT4000P/6000P and
GXT4500P/6500P display adaptor based on Raster Engine RC1000,
found on some IBM System P (pSeries) machines. This driver
- doesn't use Geometry Engine GT1000.
+ doesn't use Geometry Engine GT1000. This driver also supports
+ AGP Fire GL2/3/4 cards on x86.
config FB_PS3
tristate "PS3 GPU framebuffer driver"
diff --git a/drivers/video/fbdev/gxt4500.c b/drivers/video/fbdev/gxt4500.c
index 135d78a..1bf9894 100644
--- a/drivers/video/fbdev/gxt4500.c
+++ b/drivers/video/fbdev/gxt4500.c
@@ -670,8 +670,15 @@ static int gxt4500_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
pci_set_drvdata(pdev, info);
+#ifdef __BIG_ENDIAN
/* Set byte-swapping for DFA aperture for all pixel sizes */
pci_write_config_dword(pdev, CFG_ENDIAN0, 0x333300);
+#else /* __LITTLE_ENDIAN */
+ /* not sure what this means but fgl23 driver does that */
+ pci_write_config_dword(pdev, CFG_ENDIAN0, 0x2300);
+/* pci_write_config_dword(pdev, CFG_ENDIAN0 + 4, 0x400000);*/
+ pci_write_config_dword(pdev, CFG_ENDIAN0 + 8, 0x98530000);
+#endif
info->fbops = &gxt4500_ops;
info->flags = FBINFO_FLAG_DEFAULT;
--
Ondrej Zary
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/5] [resend] gxt4500: fix 16bpp 565 mode
2015-08-24 20:15 [PATCH 0/5] [resend] gxt4500: Make usable on x86 and fix some bugs Ondrej Zary
2015-08-24 20:15 ` [PATCH 1/5] [resend] gxt4500: enable on non-PPC architectures Ondrej Zary
@ 2015-08-24 20:15 ` Ondrej Zary
2015-08-24 20:15 ` [PATCH 3/5] [resend] gxt4500: fix color order Ondrej Zary
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Ondrej Zary @ 2015-08-24 20:15 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Tomi Valkeinen, linux-fbdev, Kernel development list
Fix wrong colors in 16bpp 565 mode.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
drivers/video/fbdev/gxt4500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/gxt4500.c b/drivers/video/fbdev/gxt4500.c
index 1bf9894..1f2fd5b 100644
--- a/drivers/video/fbdev/gxt4500.c
+++ b/drivers/video/fbdev/gxt4500.c
@@ -525,7 +525,7 @@ static int gxt4500_setcolreg(unsigned int reg, unsigned int red,
u32 val = reg;
switch (par->pixfmt) {
case DFA_PIX_16BIT_565:
- val |= (reg << 11) | (reg << 6);
+ val |= (reg << 11) | (reg << 5);
break;
case DFA_PIX_16BIT_1555:
val |= (reg << 10) | (reg << 5);
--
Ondrej Zary
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/5] [resend] gxt4500: fix color order
2015-08-24 20:15 [PATCH 0/5] [resend] gxt4500: Make usable on x86 and fix some bugs Ondrej Zary
2015-08-24 20:15 ` [PATCH 1/5] [resend] gxt4500: enable on non-PPC architectures Ondrej Zary
2015-08-24 20:15 ` [PATCH 2/5] [resend] gxt4500: fix 16bpp 565 mode Ondrej Zary
@ 2015-08-24 20:15 ` Ondrej Zary
2015-08-24 20:15 ` [PATCH 4/5] [resend] gxt4500: Use write-combining for framebuffer Ondrej Zary
2015-08-24 20:15 ` [PATCH 5/5] [resend] gxt4500: enable panning Ondrej Zary
4 siblings, 0 replies; 6+ messages in thread
From: Ondrej Zary @ 2015-08-24 20:15 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Tomi Valkeinen, linux-fbdev, Kernel development list
The color order in truecolor modes is wrong. This does not affect console but
is visible e.g. in X11 which has wrong colors.
Swap blue and red colors to fix the problem.
Fixes https://forums.gentoo.org/viewtopic-t-692740-start-0.html
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
drivers/video/fbdev/gxt4500.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/gxt4500.c b/drivers/video/fbdev/gxt4500.c
index 1f2fd5b..442b07c 100644
--- a/drivers/video/fbdev/gxt4500.c
+++ b/drivers/video/fbdev/gxt4500.c
@@ -347,11 +347,12 @@ static void gxt4500_unpack_pixfmt(struct fb_var_screeninfo *var,
break;
}
if (pixfmt != DFA_PIX_8BIT) {
- var->green.offset = var->red.length;
- var->blue.offset = var->green.offset + var->green.length;
+ var->blue.offset = 0;
+ var->green.offset = var->blue.length;
+ var->red.offset = var->green.offset + var->green.length;
if (var->transp.length)
var->transp.offset - var->blue.offset + var->blue.length;
+ var->red.offset + var->red.length;
}
}
--
Ondrej Zary
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/5] [resend] gxt4500: Use write-combining for framebuffer
2015-08-24 20:15 [PATCH 0/5] [resend] gxt4500: Make usable on x86 and fix some bugs Ondrej Zary
` (2 preceding siblings ...)
2015-08-24 20:15 ` [PATCH 3/5] [resend] gxt4500: fix color order Ondrej Zary
@ 2015-08-24 20:15 ` Ondrej Zary
2015-08-24 20:15 ` [PATCH 5/5] [resend] gxt4500: enable panning Ondrej Zary
4 siblings, 0 replies; 6+ messages in thread
From: Ondrej Zary @ 2015-08-24 20:15 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Tomi Valkeinen, linux-fbdev, Kernel development list
Use write-combining for framebuffer to greatly improve performance on x86.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
drivers/video/fbdev/gxt4500.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/gxt4500.c b/drivers/video/fbdev/gxt4500.c
index 442b07c..e0d1550 100644
--- a/drivers/video/fbdev/gxt4500.c
+++ b/drivers/video/fbdev/gxt4500.c
@@ -142,7 +142,7 @@ static const unsigned char watfmt[] = {
struct gxt4500_par {
void __iomem *regs;
-
+ int wc_cookie;
int pixfmt; /* pixel format, see DFA_PIX_* values */
/* PLL parameters */
@@ -663,7 +663,7 @@ static int gxt4500_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
info->fix.smem_start = fb_phys;
info->fix.smem_len = pci_resource_len(pdev, 1);
- info->screen_base = pci_ioremap_bar(pdev, 1);
+ info->screen_base = ioremap_wc(fb_phys, info->fix.smem_len);
if (!info->screen_base) {
dev_err(&pdev->dev, "gxt4500: cannot map framebuffer\n");
goto err_unmap_regs;
@@ -671,6 +671,9 @@ static int gxt4500_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
pci_set_drvdata(pdev, info);
+ par->wc_cookie = arch_phys_wc_add(info->fix.smem_start,
+ info->fix.smem_len);
+
#ifdef __BIG_ENDIAN
/* Set byte-swapping for DFA aperture for all pixel sizes */
pci_write_config_dword(pdev, CFG_ENDIAN0, 0x333300);
@@ -735,6 +738,7 @@ static void gxt4500_remove(struct pci_dev *pdev)
return;
par = info->par;
unregister_framebuffer(info);
+ arch_phys_wc_del(par->wc_cookie);
fb_dealloc_cmap(&info->cmap);
iounmap(par->regs);
iounmap(info->screen_base);
--
Ondrej Zary
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 5/5] [resend] gxt4500: enable panning
2015-08-24 20:15 [PATCH 0/5] [resend] gxt4500: Make usable on x86 and fix some bugs Ondrej Zary
` (3 preceding siblings ...)
2015-08-24 20:15 ` [PATCH 4/5] [resend] gxt4500: Use write-combining for framebuffer Ondrej Zary
@ 2015-08-24 20:15 ` Ondrej Zary
4 siblings, 0 replies; 6+ messages in thread
From: Ondrej Zary @ 2015-08-24 20:15 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Tomi Valkeinen, linux-fbdev, Kernel development list
The driver implements pan_display but the corresponding flags are not set.
Add FBINFO_HWACCEL_XPAN and FBINFO_HWACCEL_YPAN to flags to allow HW
accelerated panning (for fast scrolling).
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
drivers/video/fbdev/gxt4500.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/gxt4500.c b/drivers/video/fbdev/gxt4500.c
index e0d1550..88a3cf6 100644
--- a/drivers/video/fbdev/gxt4500.c
+++ b/drivers/video/fbdev/gxt4500.c
@@ -685,7 +685,8 @@ static int gxt4500_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
#endif
info->fbops = &gxt4500_ops;
- info->flags = FBINFO_FLAG_DEFAULT;
+ info->flags = FBINFO_FLAG_DEFAULT | FBINFO_HWACCEL_XPAN |
+ FBINFO_HWACCEL_YPAN;
err = fb_alloc_cmap(&info->cmap, 256, 0);
if (err) {
--
Ondrej Zary
^ permalink raw reply related [flat|nested] 6+ messages in thread