From: YH Huang <yh.huang@mediatek.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH] pwm-backlight: fix the panel power sequence
Date: Fri, 16 Oct 2015 08:50:37 +0000 [thread overview]
Message-ID: <1444985437.18373.3.camel@mtksdaap41> (raw)
In-Reply-To: <20151016083616.GA7858@pengutronix.de>
On Fri, 2015-10-16 at 10:36 +0200, Sascha Hauer wrote:
> On Fri, Oct 16, 2015 at 09:37:34AM +0800, YH Huang wrote:
> > In order to match the panel power sequence, disable the enable_gpio
> > in the probe function. Also, reorder the code in the power_on and
> > power_off function to match the timing.
> > @@ -241,8 +242,7 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> > pb->dev = &pdev->dev;
> > pb->enabled = false;
> >
> > - pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
> > - GPIOD_OUT_HIGH);
> > + pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable");
>
> Please actually test your patches. This change here won't compile.
>
> Sascha
>
I will send patch v2 to fix it.
YH Huang
prev parent reply other threads:[~2015-10-16 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 1:37 [RESEND PATCH] pwm-backlight: fix the panel power sequence YH Huang
2015-10-16 2:42 ` kbuild test robot
2015-10-16 8:49 ` YH Huang
2015-10-16 8:31 ` Lucas Stach
2015-10-22 15:29 ` YH Huang
2015-10-16 8:36 ` Sascha Hauer
2015-10-16 8:50 ` YH Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444985437.18373.3.camel@mtksdaap41 \
--to=yh.huang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).