From: YH Huang <yh.huang@mediatek.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] pwm-backlight: fix the panel power sequence
Date: Wed, 04 Nov 2015 01:47:36 +0000 [thread overview]
Message-ID: <1446601656.15340.11.camel@mtksdaap41> (raw)
In-Reply-To: <1446548924.3373.3.camel@pengutronix.de>
On Tue, 2015-11-03 at 12:08 +0100, Philipp Zabel wrote:
> Hi YH,
>
> Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang:
> > > The reasoning is that devices where there is no phandle link pointing to
> > > the backlight (for example from a simple-panel node), we should keep the
> > > current default behaviour (enable during probe).
> >
> > I have a little problem for the current default behaviour.
> > Should we enable during probe?
>
> Here I mean enabling the backlight (at the end of the probe function),
> not enabling the GPIO already when requesting it.
>
> > Before this patch ( http://patchwork.ozlabs.org/patch/324690/ ),
> > we disable "enable-gpio" in the probe function.
>
> While before this patch the GPIO would be initialized in the disabled
> state, the call to backlight_update_status at the end of the probe
> function would still enable the backlight afterwards.
Based on this, could we disable it initially and update in the
backlight_update_status function?
Like this,
if (pb->enable_gpio) {
if (phandle &&
gpiod_get_direction(pb->enable_gpio) = GPIOF_DIR_OUT &&
gpiod_get_value(pb->enable_gpio) = 1)
gpiod_direction_output(pb->enable_gpio, 1);
else
gpiod_direction_output(pb->enable_gpio, 0);
}
And then update with props.brightness in backlight_update_status.
I am not sure, maybe I miss something.
Regards,
YH Huang
next prev parent reply other threads:[~2015-11-04 1:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 9:17 [PATCH v2] pwm-backlight: fix the panel power sequence YH Huang
2015-10-16 9:36 ` Philipp Zabel
2015-10-22 15:12 ` YH Huang
2015-10-29 15:40 ` Philipp Zabel
2015-10-30 7:41 ` YH Huang
2015-10-30 10:34 ` Philipp Zabel
2015-11-03 8:11 ` YH Huang
2015-11-03 11:08 ` Philipp Zabel
2015-11-04 1:47 ` YH Huang [this message]
2015-11-05 9:40 ` Philipp Zabel
2015-11-06 8:31 ` YH Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446601656.15340.11.camel@mtksdaap41 \
--to=yh.huang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).