From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Tue, 10 Nov 2015 22:39:55 +0000 Subject: Re: [PATCH] video: constify geode ops structures Message-Id: <1447195195.2701.103.camel@perches.com> List-Id: References: <1447018493-20631-1-git-send-email-Julia.Lawall@lip6.fr> <20151108221624.GP18797@mwanda> <20151110063821.GA31014@infradead.org> <1447188569.2701.91.camel@perches.com> <20151110220244.GU7289@mwanda> <1447193832.2701.102.camel@perches.com> <20151110223400.GX18797@mwanda> In-Reply-To: <20151110223400.GX18797@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Kees Cook , Christoph Hellwig , Julia Lawall , Jean-Christophe Plagniol-Villard , kernel-janitors@vger.kernel.org, Tomi Valkeinen , linux-geode@lists.infradead.org, linux-fbdev@vger.kernel.org, LKML On Wed, 2015-11-11 at 01:34 +0300, Dan Carpenter wrote: > On Tue, Nov 10, 2015 at 02:17:12PM -0800, Joe Perches wrote: > > On Wed, 2015-11-11 at 01:02 +0300, Dan Carpenter wrote: > > > On Tue, Nov 10, 2015 at 12:49:29PM -0800, Joe Perches wrote: > > > > Is there a warning/info message produced by gcc and the > > > > plug-in when a non-const declaration is converted to > > > > const because of this attribute? > > > > > > I'm not sure I understand the question. What would the warning > > > say? > > > > Perhaps something like: > > > > declaration of struct converted to const by > > __attribute__((do_const)) > > No one will ever think to turn on that output. By the time they think > of turning it on, it means they have already figured out the issue. Dubious assertion.