From: Philipp Zabel <p.zabel@pengutronix.de>
To: Manfred Schlaegl <manfred.schlaegl@gmx.at>
Cc: linux-fbdev@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Manfred Schlaegl <manfred.schlaegl@ginzinger.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Steve Longerbeam <slongerbeam@gmail.com>,
Deepak Das <deepak_das@mentor.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [RFC PATCH 1/2] drm: add support for for clk and de polarity
Date: Wed, 25 Nov 2015 17:22:21 +0000 [thread overview]
Message-ID: <1448472141.3390.17.camel@pengutronix.de> (raw)
In-Reply-To: <55A6813A.8090706@gmx.at>
Am Mittwoch, den 15.07.2015, 17:50 +0200 schrieb Manfred Schlaegl:
> To get full support for parallel and LVDS displays with drm:
> Add representation for clock and data enable polarity in drm_display_mode
> flags (similar to HSYNC/VSYNC polarity) and update conversion functions
> from/to videomode accordingly.
>
> This is especially important for embedded devices where parallel(RGB) and
> LVDS displays are still widely used and drm already plays an important
> role.
>
> Tested on Freescale i.MX53(parallel) and i.MX6(LVDS).
>
> Background:
> There was the ability to set polarity of clock and data enable signals
> in devicetree(display-timing), struct display_timing and struct videomode,
> but there was no representation for this in struct drm_display_mode.
> Example on Freescale i.MX53/i.MX6 SoC's:
> * A parallel display using different clock polarity is set up using
> display-timing in devicetree
> * ipuv3 parallel outputs clock with wrong polarity
>
> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@gmx.at>
Any comments on whether data enable and pixel clock polarity flags can
be added to the visible DRM_MODE_FLAGs, and if not, where else this
information should be kept? struct drm_display_info?
This patch and the following IPUv3 patch are useful and necessary for
quite some panels connected to i.MX SoCs, but adding DRM_MODE_FLAGs is
somewhat out of my jurisdiction.
best regards
Philipp
next prev parent reply other threads:[~2015-11-25 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 15:44 [RFC PATCH 0/2] drm: add support for for clk and de polarity & gpu: ipu-v3: use clock and de polarit Manfred Schlaegl
[not found] ` <55A67FDB.8010602-RbZlAiThDcE@public.gmane.org>
2015-07-15 15:50 ` [RFC PATCH 1/2] drm: add support for for clk and de polarity Manfred Schlaegl
2015-11-25 17:22 ` Philipp Zabel [this message]
2015-11-26 14:20 ` Manfred Schlaegl
2015-11-27 7:37 ` Tomi Valkeinen
2015-11-30 21:09 ` Philipp Zabel
2015-07-15 15:51 ` [RFC PATCH 2/2] gpu: ipu-v3: use clock and de polarity from videomode Manfred Schlaegl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448472141.3390.17.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=deepak_das@mentor.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred.schlaegl@ginzinger.com \
--cc=manfred.schlaegl@gmx.at \
--cc=plagnioj@jcrosoft.com \
--cc=slongerbeam@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).