From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: linux-fbdev@vger.kernel.org
Subject: [PATCH v2 2/3] fbdev: omap2: panel-dpi: make (limited) use of a reset gpio
Date: Sun, 20 Dec 2015 11:13:21 +0000 [thread overview]
Message-ID: <1450610002-10531-3-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
Some displays have a reset input. To assert that the display is
functional the reset gpio must be deasserted.
Teach the driver to get and drive such a gpio accordingly.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
--
Changes since (implicit) v1, sent with
Message-Id: 1449753107-11410-4-git-send-email-uwe@kleine-koenig.org :
- never assert reset because there are too many different panels with
too many different needs for their reset.
- split out dt binding changes
- reword commit log
---
drivers/video/fbdev/omap2/displays-new/panel-dpi.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c
index e780fd4f8b46..201a1c1a6f42 100644
--- a/drivers/video/fbdev/omap2/displays-new/panel-dpi.c
+++ b/drivers/video/fbdev/omap2/displays-new/panel-dpi.c
@@ -213,6 +213,16 @@ static int panel_dpi_probe_of(struct platform_device *pdev)
ddata->enable_gpio = gpio;
+ /*
+ * Many different panels are supported by this driver and there are
+ * probably very different needs for their reset pins in regards to
+ * timing and order relative to the enable gpio. So for now it's just
+ * ensured that the reset line isn't active.
+ */
+ gpio = devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_LOW);
+ if (IS_ERR(gpio))
+ return PTR_ERR(gpio);
+
ddata->backlight_gpio = -ENOENT;
r = of_get_display_timing(node, "panel-timing", &timing);
--
2.6.2
next reply other threads:[~2015-12-20 11:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 11:13 Uwe Kleine-König [this message]
2016-02-16 13:01 ` [PATCH v2 2/3] fbdev: omap2: panel-dpi: make (limited) use of a reset gpio Tomi Valkeinen
2016-02-16 13:31 ` Uwe Kleine-König
2016-02-16 13:33 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450610002-10531-3-git-send-email-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).