linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 1/7] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*()
Date: Thu, 28 Apr 2016 15:18:31 +0000	[thread overview]
Message-ID: <1461856717-6476-2-git-send-email-noralf@tronnes.org> (raw)
In-Reply-To: <1461856717-6476-1-git-send-email-noralf@tronnes.org>

Now that drm_fb_helper gets deferred io support, the
drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule
a worker that will call the (struct drm_framebuffer *)->funcs->dirty()
function. This will break this driver so use the
sys_{fillrect,copyarea,imageblit} functions directly.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/udl/udl_fb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index fd1eb9d..a52de2f 100644
--- a/drivers/gpu/drm/udl/udl_fb.c
+++ b/drivers/gpu/drm/udl/udl_fb.c
@@ -287,7 +287,7 @@ static void udl_fb_fillrect(struct fb_info *info, const struct fb_fillrect *rect
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_fillrect(info, rect);
+	sys_fillrect(info, rect);
 
 	udl_handle_damage(&ufbdev->ufb, rect->dx, rect->dy, rect->width,
 			  rect->height);
@@ -297,7 +297,7 @@ static void udl_fb_copyarea(struct fb_info *info, const struct fb_copyarea *regi
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_copyarea(info, region);
+	sys_copyarea(info, region);
 
 	udl_handle_damage(&ufbdev->ufb, region->dx, region->dy, region->width,
 			  region->height);
@@ -307,7 +307,7 @@ static void udl_fb_imageblit(struct fb_info *info, const struct fb_image *image)
 {
 	struct udl_fbdev *ufbdev = info->par;
 
-	drm_fb_helper_sys_imageblit(info, image);
+	sys_imageblit(info, image);
 
 	udl_handle_damage(&ufbdev->ufb, image->dx, image->dy, image->width,
 			  image->height);
-- 
2.2.2


  reply	other threads:[~2016-04-28 15:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 15:18 [PATCH v4 0/7] drm: Add fbdev deferred io support to helpers Noralf Trønnes
2016-04-28 15:18 ` Noralf Trønnes [this message]
2016-04-28 15:18 ` [PATCH v4 2/7] drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*() Noralf Trønnes
2016-04-28 15:18 ` [PATCH v4 3/7] drm/fb-helper: Add fb_deferred_io support Noralf Trønnes
2016-04-29 12:50   ` Tomi Valkeinen
2016-04-29 14:47     ` Noralf Trønnes
2016-05-02 14:24       ` Daniel Vetter
2016-04-29 14:55     ` Daniel Vetter
2016-04-29 15:00       ` Tomi Valkeinen
2016-04-29 15:36         ` Daniel Vetter
2016-04-29 15:38           ` Daniel Vetter
2016-04-28 15:18 ` [PATCH v4 4/7] fbdev: fb_defio: Export fb_deferred_io_mmap Noralf Trønnes
2016-04-29 14:07   ` Tomi Valkeinen
2016-04-28 15:18 ` [PATCH v4 5/7] drm/fb-cma-helper: Add fb_deferred_io support Noralf Trønnes
2016-04-28 15:18 ` [PATCH v4 6/7] drm/qxl: Use drm_fb_helper deferred_io support Noralf Trønnes
2016-04-28 15:18 ` [PATCH v4 7/7] drm/udl: " Noralf Trønnes
2016-04-29 14:57 ` [PATCH v4 0/7] drm: Add fbdev deferred io support to helpers Daniel Vetter
2016-05-02 14:26   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461856717-6476-2-git-send-email-noralf@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).