linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] video: smscufx: remove unused variable
@ 2016-05-25 12:31 Sudip Mukherjee
  2016-09-27  8:48 ` Tomi Valkeinen
  0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2016-05-25 12:31 UTC (permalink / raw)
  To: Steve Glendinning, Jean-Christophe Plagniol-Villard,
	Tomi Valkeinen
  Cc: linux-kernel, linux-fbdev, Sudip Mukherjee

The variable was only assigned with the pointer but was never used.
We can safely remove it.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
 drivers/video/fbdev/smscufx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c
index 9279e5f..ec2e7e3 100644
--- a/drivers/video/fbdev/smscufx.c
+++ b/drivers/video/fbdev/smscufx.c
@@ -1761,10 +1761,8 @@ error:
 static void ufx_usb_disconnect(struct usb_interface *interface)
 {
 	struct ufx_data *dev;
-	struct fb_info *info;
 
 	dev = usb_get_intfdata(interface);
-	info = dev->info;
 
 	pr_debug("USB disconnect starting\n");
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] video: smscufx: remove unused variable
  2016-05-25 12:31 [PATCH] video: smscufx: remove unused variable Sudip Mukherjee
@ 2016-09-27  8:48 ` Tomi Valkeinen
  0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2016-09-27  8:48 UTC (permalink / raw)
  To: Sudip Mukherjee, Steve Glendinning; +Cc: linux-kernel, linux-fbdev


[-- Attachment #1.1: Type: text/plain, Size: 815 bytes --]

On 25/05/16 15:19, Sudip Mukherjee wrote:
> The variable was only assigned with the pointer but was never used.
> We can safely remove it.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>  drivers/video/fbdev/smscufx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c
> index 9279e5f..ec2e7e3 100644
> --- a/drivers/video/fbdev/smscufx.c
> +++ b/drivers/video/fbdev/smscufx.c
> @@ -1761,10 +1761,8 @@ error:
>  static void ufx_usb_disconnect(struct usb_interface *interface)
>  {
>  	struct ufx_data *dev;
> -	struct fb_info *info;
>  
>  	dev = usb_get_intfdata(interface);
> -	info = dev->info;
>  
>  	pr_debug("USB disconnect starting\n");
>  
> 

Thanks, queued for 4.9.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-27  8:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-25 12:31 [PATCH] video: smscufx: remove unused variable Sudip Mukherjee
2016-09-27  8:48 ` Tomi Valkeinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).