From: Philipp Zabel <p.zabel@pengutronix.de>
To: Steve Longerbeam <slongerbeam@gmail.com>
Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org,
Steve Longerbeam <steve_longerbeam@mentor.com>
Subject: Re: [PATCH v3 10/12] gpu: ipu-v3: Add FSU channel linking support
Date: Mon, 01 Aug 2016 09:13:21 +0000 [thread overview]
Message-ID: <1470042801.3025.17.camel@pengutronix.de> (raw)
In-Reply-To: <1469994147-17549-11-git-send-email-steve_longerbeam@mentor.com>
Am Sonntag, den 31.07.2016, 12:42 -0700 schrieb Steve Longerbeam:
> Adds functions to link and unlink source channels to sink
> channels in the FSU:
>
> int ipu_fsu_link(struct ipu_soc *ipu, int src_ch, int sink_ch);
> int ipu_fsu_unlink(struct ipu_soc *ipu, int src_ch, int sink_ch);
>
> The channels numbers are usually IDMAC channels, but they can also be
> channels that do not transfer data to or from memory. The following
> convenience functions can be used in place of ipu_fsu_link/unlink()
> when both source and sink channels are IDMAC channels:
>
> int ipu_idmac_link(struct ipuv3_channel *src, struct ipuv3_channel *sink);
> int ipu_idmac_unlink(struct ipuv3_channel *src, struct ipuv3_channel *sink);
>
> So far the following links are supported:
>
> IPUV3_CHANNEL_IC_PRP_ENC_MEM -> IPUV3_CHANNEL_MEM_ROT_ENC
> PUV3_CHANNEL_IC_PRP_VF_MEM -> IPUV3_CHANNEL_MEM_ROT_VF
> IPUV3_CHANNEL_IC_PP_MEM -> IPUV3_CHANNEL_MEM_ROT_PP
> IPUV3_CHANNEL_CSI_DIRECT -> IPUV3_CHANNEL_CSI_VDI_PREV
Looks good to me, thanks. Are you sure though that the target of the CSI
direct channel is VDI_PREV? I would have assumed the CSI input is fed
into VDI_NEXT, while CUR and PREV are read from memory.
regards
Philipp
next prev parent reply other threads:[~2016-08-01 9:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 19:42 [PATCH v3 00/12] IPUv3 prep for i.MX5/6 v4l2 staging drivers, v3 Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 01/12] gpu: ipu-cpmem: Add ipu_cpmem_set_uv_offset() Steve Longerbeam
2016-08-01 9:13 ` Philipp Zabel
2016-08-01 20:15 ` Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 02/12] gpu: ipu-cpmem: Add ipu_cpmem_get_burstsize() Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 03/12] gpu: ipu-v3: Add ipu_get_num() Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 04/12] gpu: ipu-v3: Add VDI input IDMAC channels Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 05/12] gpu: ipu-v3: set correct full sensor frame for PAL/NTSC Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 06/12] gpu: ipu-v3: Fix CSI data format for 16-bit media bus formats Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 07/12] gpu: ipu-v3: Fix IRT usage Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 08/12] gpu: ipu-v3: rename CSI client device Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 09/12] gpu: ipu-v3: Add Video Deinterlacer unit Steve Longerbeam
2016-08-01 9:13 ` Philipp Zabel
2016-08-01 21:02 ` Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 10/12] gpu: ipu-v3: Add FSU channel linking support Steve Longerbeam
2016-08-01 9:13 ` Philipp Zabel [this message]
2016-08-01 20:35 ` Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 11/12] gpu: ipu-ic: Add complete image conversion support with tiling Steve Longerbeam
2016-07-31 19:42 ` [PATCH v3 12/12] gpu: ipu-ic: allow multiple handles to ic Steve Longerbeam
2016-07-31 19:55 ` [PATCH v3 00/12] IPUv3 prep for i.MX5/6 v4l2 staging drivers, v3 Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470042801.3025.17.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=slongerbeam@gmail.com \
--cc=steve_longerbeam@mentor.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).