From: Arnd Bergmann <arnd@arndb.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: vgacon: Don't build on arm64
Date: Wed, 08 Jan 2014 13:48:28 +0000 [thread overview]
Message-ID: <14702006.daUmPS66ac@wuerfel> (raw)
In-Reply-To: <1387323421-26126-1-git-send-email-broonie@kernel.org>
On Wednesday 08 January 2014 15:43:20 Tomi Valkeinen wrote:
> On 2013-12-18 01:37, Mark Brown wrote:
> > From: Mark Brown <broonie@linaro.org>
> >
> > arm64 is unlikely to have a VGA console and does not export screen_info
> > causing build failures if the driver is build, for example in all*config.
> > Add a dependency on !ARM64 to prevent this.
> >
> > This list is getting quite long, it may be easier to depend on a symbol
> > which architectures that do support the driver can select.
>
> I agree, that depends on looks horrible =).
I've suggested creating a "CONFIG_PC_IO" symbol before that could used
to simplify this one and a couple of other similar Kconfig statements.
It is unfortunately a bit tricky because out of the dozen drivers that
are similar to this one, each one has a slightly different list of
architectures, and it's not clear which of the differences are intentional
rather than mistakes.
Arnd
next prev parent reply other threads:[~2014-01-08 13:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 23:37 [PATCH] video: vgacon: Don't build on arm64 Mark Brown
2014-01-08 13:43 ` Tomi Valkeinen
2014-01-08 13:48 ` Arnd Bergmann [this message]
2014-01-08 14:34 ` Geert Uytterhoeven
2014-01-08 14:48 ` Arnd Bergmann
2014-01-08 15:05 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14702006.daUmPS66ac@wuerfel \
--to=arnd@arndb.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox