[PATCH] video: don't print error when adding adapter fails

[PATCH] video: don't print error when adding adapter fails

[Wolfram Sang]

Since v4.8-rc1, the I2C core will print detailed information when adding an I2C
adapter fails. So, drivers can skip this now.

Should go via subsystem tree, I'd think.

Wolfram Sang (1):
  video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding
    adapter fails

 drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

-- 
2.8.1

[PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails

[Wolfram Sang]

The core will do this for us now.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
 drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index c87e17afb3e2c9..76d206857e3e2c 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -162,12 +162,7 @@ int mb862xx_i2c_init(struct mb862xxfb_par *par)
 	mb862xx_i2c_adapter.algo_data = par;
 	par->adap = &mb862xx_i2c_adapter;
 
-	ret = i2c_add_adapter(par->adap);
-	if (ret < 0) {
-		dev_err(par->dev, "failed to add %s\n",
-			mb862xx_i2c_adapter.name);
-	}
-	return ret;
+	return i2c_add_adapter(par->adap);
 }
 
 void mb862xx_i2c_exit(struct mb862xxfb_par *par)
-- 
2.8.1

Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails

[Tomi Valkeinen]

[-- Attachment #1.1: Type: text/plain, Size: 420 bytes --]



On 09/08/16 14:27, Wolfram Sang wrote:
> The core will do this for us now.
> 
> Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
> ---
>  drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Thanks, queued for v4.9.

One comment: the patch description should be "stand-alone" text, not a
continuation of the subject. I fixed this.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]


> One comment: the patch description should be "stand-alone" text, not a
> continuation of the subject. I fixed this.

I see. Will keep that in mind for the future. Thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]