* [PATCH] video: don't print error when adding adapter fails
@ 2016-08-09 11:27 Wolfram Sang
2016-08-09 11:27 ` [PATCH] video: fbdev: mb862xx: mb862xx-i2c: " Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2016-08-09 11:27 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-i2c, Wolfram Sang, linux-fbdev
Since v4.8-rc1, the I2C core will print detailed information when adding an I2C
adapter fails. So, drivers can skip this now.
Should go via subsystem tree, I'd think.
Wolfram Sang (1):
video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding
adapter fails
drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
--
2.8.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails
2016-08-09 11:27 [PATCH] video: don't print error when adding adapter fails Wolfram Sang
@ 2016-08-09 11:27 ` Wolfram Sang
2016-08-10 10:24 ` Tomi Valkeinen
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2016-08-09 11:27 UTC (permalink / raw)
To: linux-kernel
Cc: linux-i2c, Wolfram Sang, Jean-Christophe Plagniol-Villard,
Tomi Valkeinen, linux-fbdev
The core will do this for us now.
Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index c87e17afb3e2c9..76d206857e3e2c 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -162,12 +162,7 @@ int mb862xx_i2c_init(struct mb862xxfb_par *par)
mb862xx_i2c_adapter.algo_data = par;
par->adap = &mb862xx_i2c_adapter;
- ret = i2c_add_adapter(par->adap);
- if (ret < 0) {
- dev_err(par->dev, "failed to add %s\n",
- mb862xx_i2c_adapter.name);
- }
- return ret;
+ return i2c_add_adapter(par->adap);
}
void mb862xx_i2c_exit(struct mb862xxfb_par *par)
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails
2016-08-09 11:27 ` [PATCH] video: fbdev: mb862xx: mb862xx-i2c: " Wolfram Sang
@ 2016-08-10 10:24 ` Tomi Valkeinen
2016-08-10 10:43 ` Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Tomi Valkeinen @ 2016-08-10 10:24 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel
Cc: linux-i2c, Jean-Christophe Plagniol-Villard, linux-fbdev
[-- Attachment #1.1: Type: text/plain, Size: 420 bytes --]
On 09/08/16 14:27, Wolfram Sang wrote:
> The core will do this for us now.
>
> Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
> ---
> drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Thanks, queued for v4.9.
One comment: the patch description should be "stand-alone" text, not a
continuation of the subject. I fixed this.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-10 10:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-09 11:27 [PATCH] video: don't print error when adding adapter fails Wolfram Sang
2016-08-09 11:27 ` [PATCH] video: fbdev: mb862xx: mb862xx-i2c: " Wolfram Sang
2016-08-10 10:24 ` Tomi Valkeinen
2016-08-10 10:43 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).