From: Johannes Berg <johannes@sipsolutions.net>
To: "sedat.dilek@gmail.com" <sedat.dilek@gmail.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thorsten Leemhuis <thl@ct.de>
Subject: Re: [drm-intel-nightly] 2016y-07m-14d-21h-13m-02s UTC: locking dependency: drm_modeset_lock_all() ||
Date: Wed, 17 Aug 2016 19:36:42 +0000 [thread overview]
Message-ID: <1471462602.5173.13.camel@sipsolutions.net> (raw)
In-Reply-To: <CA+icZUWn+zFjCHT+O6ihb7+kQDmn9N3Y588F45_=U=KYHZsoAw@mail.gmail.com>
On Wed, 2016-08-17 at 19:27 +0000, Sedat Dilek wrote:
>Â
> > > The call-trace is reproducible with my setup and seen on every
> > > boot.
Might have been nice to keep the backtrace when adding new people :)
I found it here:
https://lists.freedesktop.org/archives/intel-gfx/2016-July/100695.html
> [ CC Peter, Johannes and Thorsten "The regression reporter" ]
>
> Peter has 2 fixes from Johannes in peterz/queue.git#locking/urgent
> which fix the issue for me.
>
> [1/2] Revert "drm/fb-helper: Reduce READ_ONCE(master) to
> lockless_dereference"
> [2/2] locking/barriers: suppress sparse warnings in
> lockless_dereference()
I don't see how those could fix it. The second one is a pure compile-
time issue, so it's completely irrelevant - it should not change code
generation in any way.
The first one, reverting to READ_ONCE(), does change the code a bit,
but since lockless_dereference() has no lockdep involvement, I don't
see how that could have any impact on a lockdep report.
Judging from the lockdep report, you have a pretty simple ABBA deadlock
there, but I really don't see how the changes could have any impact.
johannes
next prev parent reply other threads:[~2016-08-17 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+icZUUUUCybFnneuhVVT4Z_vymMcLp4HdCe3CDY5SerFnP+tg@mail.gmail.com>
2016-07-15 8:40 ` [drm-intel-nightly] 2016y-07m-14d-21h-13m-02s UTC: locking dependency: drm_modeset_lock_all() || Chris Wilson
2016-07-15 10:37 ` Sedat Dilek
2016-08-17 19:27 ` Sedat Dilek
2016-08-17 19:36 ` Johannes Berg [this message]
2016-08-01 13:33 ` [Intel-gfx] [drm-intel-nightly] 2016y-07m-14d-21h-13m-02s UTC: locking dependency: drm_modeset_l Jani Nikula
2016-08-02 17:47 ` Sedat Dilek
2016-08-03 8:42 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471462602.5173.13.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=plagnioj@jcrosoft.com \
--cc=sedat.dilek@gmail.com \
--cc=thl@ct.de \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).