* [PATCH] omapfb: fix return value check in dsi_bind()
@ 2016-09-17 15:53 Wei Yongjun
2016-09-20 9:22 ` Peter Ujfalusi
2016-09-27 8:04 ` Tomi Valkeinen
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-09-17 15:53 UTC (permalink / raw)
To: linux-fbdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix the retrn value check which testing the wrong variable
in dsi_bind().
Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
index 9e4800a..951dd93 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
@@ -5348,7 +5348,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
resource_size(res));
- if (!dsi->proto_base) {
+ if (!dsi->phy_base) {
DSSERR("can't ioremap DSI PHY\n");
return -ENOMEM;
}
@@ -5368,7 +5368,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
resource_size(res));
- if (!dsi->proto_base) {
+ if (!dsi->pll_base) {
DSSERR("can't ioremap DSI PLL\n");
return -ENOMEM;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] omapfb: fix return value check in dsi_bind()
2016-09-17 15:53 [PATCH] omapfb: fix return value check in dsi_bind() Wei Yongjun
@ 2016-09-20 9:22 ` Peter Ujfalusi
2016-09-27 8:04 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2016-09-20 9:22 UTC (permalink / raw)
To: linux-fbdev
On 09/17/16 18:53, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the retrn value check which testing the wrong variable
> in dsi_bind().
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> index 9e4800a..951dd93 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> @@ -5348,7 +5348,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>
> dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
> resource_size(res));
> - if (!dsi->proto_base) {
> + if (!dsi->phy_base) {
> DSSERR("can't ioremap DSI PHY\n");
> return -ENOMEM;
> }
> @@ -5368,7 +5368,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>
> dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
> resource_size(res));
> - if (!dsi->proto_base) {
> + if (!dsi->pll_base) {
> DSSERR("can't ioremap DSI PLL\n");
> return -ENOMEM;
> }
>
--
Péter
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] omapfb: fix return value check in dsi_bind()
2016-09-17 15:53 [PATCH] omapfb: fix return value check in dsi_bind() Wei Yongjun
2016-09-20 9:22 ` Peter Ujfalusi
@ 2016-09-27 8:04 ` Tomi Valkeinen
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2016-09-27 8:04 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1.1: Type: text/plain, Size: 1336 bytes --]
On 17/09/16 18:53, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the retrn value check which testing the wrong variable
> in dsi_bind().
>
> Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> index 9e4800a..951dd93 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> @@ -5348,7 +5348,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>
> dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
> resource_size(res));
> - if (!dsi->proto_base) {
> + if (!dsi->phy_base) {
> DSSERR("can't ioremap DSI PHY\n");
> return -ENOMEM;
> }
> @@ -5368,7 +5368,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>
> dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
> resource_size(res));
> - if (!dsi->proto_base) {
> + if (!dsi->pll_base) {
> DSSERR("can't ioremap DSI PLL\n");
> return -ENOMEM;
> }
>
Thanks, queued for 4.9.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-27 8:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-17 15:53 [PATCH] omapfb: fix return value check in dsi_bind() Wei Yongjun
2016-09-20 9:22 ` Peter Ujfalusi
2016-09-27 8:04 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).