From: Martin Kaiser <martin@kaiser.cx>
To: Sascha Hauer <kernel@pengutronix.de>, linux-fbdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM
Date: Tue, 22 Nov 2016 07:54:18 +0000 [thread overview]
Message-ID: <1479801258-3765-1-git-send-email-martin@kaiser.cx> (raw)
The HM and TM fields in the LCDC DMA Control Register are 7 bits wide.
Use the correct mask to allow setting all possible bits.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
This bug was discovered on a board that uses DMACR_TM(16). We ended up
with TM=0 in the register, the upper three bits were filtered out.
The LCD DMA Control Register is described in section 33.3.16 of the
IMX25 reference manual.
include/linux/platform_data/video-imxfb.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/platform_data/video-imxfb.h b/include/linux/platform_data/video-imxfb.h
index 18e9083..858c66d 100644
--- a/include/linux/platform_data/video-imxfb.h
+++ b/include/linux/platform_data/video-imxfb.h
@@ -48,8 +48,8 @@
#define LSCR1_GRAY1(x) (((x) & 0xf))
#define DMACR_BURST (1 << 31)
-#define DMACR_HM(x) (((x) & 0xf) << 16)
-#define DMACR_TM(x) ((x) & 0xf)
+#define DMACR_HM(x) (((x) & 0x7f) << 16)
+#define DMACR_TM(x) ((x) & 0x7f)
struct imx_fb_videomode {
struct fb_videomode mode;
--
1.7.10.4
next reply other threads:[~2016-11-22 7:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 7:54 Martin Kaiser [this message]
2016-11-22 8:42 ` [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Uwe Kleine-König
2016-11-23 9:31 ` Martin Kaiser
2016-11-23 9:50 ` Uwe Kleine-König
2016-11-25 8:43 ` Martin Kaiser
2016-11-28 22:43 ` [PATCH] video: imxfb: remove the macros for initializing the DMACR Martin Kaiser
2016-11-29 7:49 ` Uwe Kleine-König
2016-11-29 19:50 ` [PATCH v2] " Martin Kaiser
2016-11-29 19:57 ` Uwe Kleine-König
[not found] ` <CGME20170111124006epcas5p138afe03766a09b68eac3f93a9047ee27@epcas5p1.samsung.com>
2017-01-11 12:39 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479801258-3765-1-git-send-email-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).