linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: simran singhal <singhalsimran0@gmail.com>
To: gregkh@linuxfoundation.org
Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	outreachy-kernel@googlegroups.com
Subject: [PATCH 4/5] staging: sm750fb: Remove unnecessary else after return
Date: Mon, 27 Feb 2017 18:26:27 +0000	[thread overview]
Message-ID: <1488219268-3006-4-git-send-email-singhalsimran0@gmail.com> (raw)
In-Reply-To: <1488219268-3006-1-git-send-email-singhalsimran0@gmail.com>

This patch fixes the checkpatch warning that else is not generally
useful after a break or return.

This was done using Coccinelle:
@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
         s1

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/sm750fb/ddk750_sii164.c | 6 ++----
 drivers/staging/sm750fb/ddk750_swi2c.c  | 6 ++----
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 259006a..6906598 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -368,8 +368,7 @@ unsigned char sii164IsConnected(void)
 	hotPlugValue = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_HOT_PLUG_STATUS_MASK;
 	if (hotPlugValue = SII164_DETECT_HOT_PLUG_STATUS_ON)
 		return 1;
-	else
-		return 0;
+	return 0;
 }
 
 /*
@@ -387,8 +386,7 @@ unsigned char sii164CheckInterrupt(void)
 	detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_MONITOR_STATE_MASK;
 	if (detectReg = SII164_DETECT_MONITOR_STATE_CHANGE)
 		return 1;
-	else
-		return 0;
+	return 0;
 }
 
 /*
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c
index a4ac07c..5997349 100644
--- a/drivers/staging/sm750fb/ddk750_swi2c.c
+++ b/drivers/staging/sm750fb/ddk750_swi2c.c
@@ -199,8 +199,7 @@ static unsigned char sw_i2c_read_sda(void)
 	gpio_data = peek32(sw_i2c_data_gpio_data_reg);
 	if (gpio_data & (1 << sw_i2c_data_gpio))
 		return 1;
-	else
-		return 0;
+	return 0;
 }
 
 /*
@@ -295,8 +294,7 @@ static long sw_i2c_write_byte(unsigned char data)
 
 	if (i < 0xff)
 		return 0;
-	else
-		return -1;
+	return -1;
 }
 
 /*
-- 
2.7.4


  parent reply	other threads:[~2017-02-27 18:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 18:26 [PATCH 1/5] staging: lustre: Remove unnecessary else after return simran singhal
2017-02-27 18:26 ` [PATCH 2/5] staging: rtl8192u: " simran singhal
2017-02-27 21:25   ` [Outreachy kernel] " Julia Lawall
2017-02-27 18:26 ` [PATCH 3/5] staging: rtl8712: " simran singhal
2017-02-27 21:19   ` [Outreachy kernel] " Julia Lawall
2017-02-28 19:29     ` SIMRAN SINGHAL
2017-02-28 19:19       ` Julia Lawall
2017-02-27 18:26 ` simran singhal [this message]
2017-02-27 19:31   ` [PATCH 4/5] staging: sm750fb: " Joe Perches
2017-02-27 20:34     ` SIMRAN SINGHAL
2017-02-27 21:15   ` [Outreachy kernel] " Julia Lawall
2017-02-28 19:08     ` SIMRAN SINGHAL
2017-02-28 19:00       ` Julia Lawall
2017-02-28 19:17         ` SIMRAN SINGHAL
2017-02-27 18:26 ` [PATCH 5/5] staging: gdm724x: " simran singhal
2017-02-27 19:41   ` Joe Perches
2017-02-27 20:31     ` SIMRAN SINGHAL
2017-02-28 19:23       ` SIMRAN SINGHAL
2017-02-28 19:18         ` [Outreachy kernel] " Julia Lawall
2017-02-28 19:18         ` Joe Perches
2017-02-28 19:21           ` [Outreachy kernel] " Julia Lawall
2017-02-27 19:25 ` [PATCH 1/5] staging: lustre: " Joe Perches
2017-02-27 20:33   ` SIMRAN SINGHAL
2017-02-27 20:43     ` Joe Perches
2017-02-28 19:13       ` SIMRAN SINGHAL
2017-02-28 19:14         ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488219268-3006-4-git-send-email-singhalsimran0@gmail.com \
    --to=singhalsimran0@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).