linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: simran singhal <singhalsimran0@gmail.com>
To: gregkh@linuxfoundation.org
Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	outreachy-kernel@googlegroups.com
Subject: [PATCH 5/5] staging: gdm724x: Remove unnecessary else after return
Date: Mon, 27 Feb 2017 18:26:28 +0000	[thread overview]
Message-ID: <1488219268-3006-5-git-send-email-singhalsimran0@gmail.com> (raw)
In-Reply-To: <1488219268-3006-1-git-send-email-singhalsimran0@gmail.com>

This patch fixes the checkpatch warning that else is not generally
useful after a break or return.

This was done using Coccinelle:
@@
expression e2;
statement s1;
@@
if(e2) { ... return ...; }
-else
         s1

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/gdm724x/gdm_endian.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_endian.c b/drivers/staging/gdm724x/gdm_endian.c
index d0b43e2..4ef728f 100644
--- a/drivers/staging/gdm724x/gdm_endian.c
+++ b/drivers/staging/gdm724x/gdm_endian.c
@@ -26,30 +26,26 @@ __dev16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
 {
 	if (ed->dev_ed = ENDIANNESS_LITTLE)
 		return (__force __dev16)cpu_to_le16(x);
-	else
-		return (__force __dev16)cpu_to_be16(x);
+	return (__force __dev16)cpu_to_be16(x);
 }
 
 u16 gdm_dev16_to_cpu(struct gdm_endian *ed, __dev16 x)
 {
 	if (ed->dev_ed = ENDIANNESS_LITTLE)
 		return le16_to_cpu((__force __le16)x);
-	else
-		return be16_to_cpu((__force __be16)x);
+	return be16_to_cpu((__force __be16)x);
 }
 
 __dev32 gdm_cpu_to_dev32(struct gdm_endian *ed, u32 x)
 {
 	if (ed->dev_ed = ENDIANNESS_LITTLE)
 		return (__force __dev32)cpu_to_le32(x);
-	else
-		return (__force __dev32)cpu_to_be32(x);
+	return (__force __dev32)cpu_to_be32(x);
 }
 
 u32 gdm_dev32_to_cpu(struct gdm_endian *ed, __dev32 x)
 {
 	if (ed->dev_ed = ENDIANNESS_LITTLE)
 		return le32_to_cpu((__force __le32)x);
-	else
-		return be32_to_cpu((__force __be32)x);
+	return be32_to_cpu((__force __be32)x);
 }
-- 
2.7.4


  parent reply	other threads:[~2017-02-27 18:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 18:26 [PATCH 1/5] staging: lustre: Remove unnecessary else after return simran singhal
2017-02-27 18:26 ` [PATCH 2/5] staging: rtl8192u: " simran singhal
2017-02-27 21:25   ` [Outreachy kernel] " Julia Lawall
2017-02-27 18:26 ` [PATCH 3/5] staging: rtl8712: " simran singhal
2017-02-27 21:19   ` [Outreachy kernel] " Julia Lawall
2017-02-28 19:29     ` SIMRAN SINGHAL
2017-02-28 19:19       ` Julia Lawall
2017-02-27 18:26 ` [PATCH 4/5] staging: sm750fb: " simran singhal
2017-02-27 19:31   ` Joe Perches
2017-02-27 20:34     ` SIMRAN SINGHAL
2017-02-27 21:15   ` [Outreachy kernel] " Julia Lawall
2017-02-28 19:08     ` SIMRAN SINGHAL
2017-02-28 19:00       ` Julia Lawall
2017-02-28 19:17         ` SIMRAN SINGHAL
2017-02-27 18:26 ` simran singhal [this message]
2017-02-27 19:41   ` [PATCH 5/5] staging: gdm724x: " Joe Perches
2017-02-27 20:31     ` SIMRAN SINGHAL
2017-02-28 19:23       ` SIMRAN SINGHAL
2017-02-28 19:18         ` [Outreachy kernel] " Julia Lawall
2017-02-28 19:18         ` Joe Perches
2017-02-28 19:21           ` [Outreachy kernel] " Julia Lawall
2017-02-27 19:25 ` [PATCH 1/5] staging: lustre: " Joe Perches
2017-02-27 20:33   ` SIMRAN SINGHAL
2017-02-27 20:43     ` Joe Perches
2017-02-28 19:13       ` SIMRAN SINGHAL
2017-02-28 19:14         ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488219268-3006-5-git-send-email-singhalsimran0@gmail.com \
    --to=singhalsimran0@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).