From: Joe Perches <joe@perches.com>
To: Richa Jha <richaj@cdac.in>, gregkh@linuxfoundation.org
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: staging: sm750fb: Replace CamelCase variable names with underscores
Date: Tue, 23 May 2017 10:49:19 +0000 [thread overview]
Message-ID: <1495536559.2093.56.camel@perches.com> (raw)
In-Reply-To: <1495517476-31531-1-git-send-email-richaj@cdac.in>
On Tue, 2017-05-23 at 11:01 +0530, Richa Jha wrote:
> Replace CamelCase variable names with underscores to comply with
> the standard kernel coding style
Better would be to remove the hungarian prefixes too
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
[]
> @@ -55,7 +55,7 @@ static unsigned int get_mxclk_freq(void)
> static void set_chip_clock(unsigned int frequency)
> {
> struct pll_value pll;
> - unsigned int ulActualMxClk;
> + unsigned int ul_actual_max_clk;
unsigned int actual_max_clk;
etc...
prev parent reply other threads:[~2017-05-23 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 5:43 staging: sm750fb: Replace CamelCase variable names with underscores Richa Jha
2017-05-23 10:49 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495536559.2093.56.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richaj@cdac.in \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).