From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org, Helge Deller <deller@gmx.de>,
dri-devel@lists.freedesktop.org,
Hans de Goede <hdegoede@redhat.com>,
Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH 0/3] fbdev: Fix use-after-free caused by wrong fb_info cleanup in drivers
Date: Thu, 5 May 2022 10:30:43 +0200 [thread overview]
Message-ID: <14afd90b-0bf3-aa01-3b97-db7e29fb858a@redhat.com> (raw)
In-Reply-To: <e0bc775a-f17a-adf1-9b2c-4be91468b7f8@suse.de>
Hello Thomas,
On 5/5/22 10:16, Thomas Zimmermann wrote:
[snip]
>> Patch #1 adds a WARN_ON() to framebuffer_release() to prevent the use-after-free
>> to happen.
>>
>> Patch #2 and patch #3 fixes the simplefb and efifb drivers respectively, to
>> free the resources at the correct place.
>
> From a quick look, vesafb seems to be affected as well.
>
Right, I wrongly assumed that we only cared about efifb and simplefb but forgot
that vesafb is used when setting a VESA mode with vga=foo. I'll add it in a v2.
> Best regards
> Thomas
>
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
prev parent reply other threads:[~2022-05-05 8:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 21:51 [PATCH 0/3] fbdev: Fix use-after-free caused by wrong fb_info cleanup in drivers Javier Martinez Canillas
2022-05-04 21:56 ` [PATCH 1/3] fbdev: Prevent possible use-after-free in fb_release() Javier Martinez Canillas
2022-05-05 7:31 ` Thomas Zimmermann
2022-05-04 21:57 ` [PATCH 2/3] fbdev/simplefb: Cleanup fb_info in .fb_destroy rather than .remove Javier Martinez Canillas
2022-05-05 7:29 ` Thomas Zimmermann
2022-05-05 7:38 ` Javier Martinez Canillas
2022-05-05 8:05 ` Thomas Zimmermann
2022-05-05 8:28 ` Javier Martinez Canillas
2022-05-05 8:49 ` Thomas Zimmermann
2022-05-05 12:57 ` Daniel Vetter
2022-05-05 12:52 ` Daniel Vetter
2022-05-05 12:57 ` Javier Martinez Canillas
2022-05-04 21:58 ` [PATCH 3/3] fbdev/efifb: " Javier Martinez Canillas
2022-05-05 7:30 ` Thomas Zimmermann
2022-05-05 8:16 ` [PATCH 0/3] fbdev: Fix use-after-free caused by wrong fb_info cleanup in drivers Thomas Zimmermann
2022-05-05 8:30 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14afd90b-0bf3-aa01-3b97-db7e29fb858a@redhat.com \
--to=javierm@redhat.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).