From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 501CE3E0097; Thu, 1 Oct 2026 15:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790870265; cv=none; b=dfe6ZL7mW+iVPZwz6MxGfg7SP6F+3kDJCdGtQYVckx0rMkbW+4Bzji/ScxzGR3GeAMv2xQC+BTmK/cDbCEnncY+ozWZ5fPR1vqOf7MZuiTnoMaJ5yJbehVn1bCtm+DZVtN2++kwqgFSrMBdGJ5wqN/SKH9eGOS9T6aL6Qagdr0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790870265; c=relaxed/simple; bh=UNkHMqxGBAcD+RzwKWSXdRY112uRoXout3g80Fye6f0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VqPjbekDDgNgzF6GHhx9zXxPFNw3QwXnsug5V3U3+g2OMU8sMnOxflUvaM3JXsVT3rrPgj7FVVy7A/AQKdbG9UxsGoR0f/dlEV1UbImkmKEoHqJJ5ntdB7keZRpL7btbcIYEXYPHwQXLgkbqTT5VdXBsmzg9o5e6hOOxNr4J6Wk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=XwgacyKU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=libx+BTn; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=fUpJhl1n; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=UuCWnDvL; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="XwgacyKU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="libx+BTn"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="fUpJhl1n"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="UuCWnDvL" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EF6B721292; Thu, 1 Oct 2026 15:57:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790870258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qhF6KmmCbZRNKmOH2gXcyTapxNbzeo8YMso0EFlu0Ec=; b=XwgacyKUjFR+XxQTbtoP9EjvRsO1nbA1T0+JMuaVocRVEf0LJMYgerHbAECpvG1jhTlwl5 4sY2jMAHxuHL2Cp06Aro7KAsX98zymLmBrzmvbCtEZiq14qiv9O26w75T8C1ur1mRXW19a waBtTFI5QWXSVUpkbZvaWrepx4fwYSY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790870258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qhF6KmmCbZRNKmOH2gXcyTapxNbzeo8YMso0EFlu0Ec=; b=libx+BTnJP/eyYyYVlVz+mo7U2UONe4Ozskz0zArpfLps64VO7R2La7Zc/r33RFVVysluI 71NcGxN8IzCj/PAw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fUpJhl1n; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=UuCWnDvL DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790870253; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qhF6KmmCbZRNKmOH2gXcyTapxNbzeo8YMso0EFlu0Ec=; b=fUpJhl1n6dBhYqnLlR0TGAM+/ezNQ7Z0xRJGAEp+wUTht5sPvgY6FKc2QOE/DdYAACeo+z 8qq02G099dw/n5/QHPyaYZaHwEt/m6rSsIBKBFAVf3YF3nXGSuCcUEwCz/L8pIZfXgHP/+ wsc6jvG0GNdJd/pPSY0+gqRCrWKaJ0c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790870253; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qhF6KmmCbZRNKmOH2gXcyTapxNbzeo8YMso0EFlu0Ec=; b=UuCWnDvLvCmJTh/wRWFXg3DkW+3x+Gwp5h1Go7syIhVsUw53jEjbVAobh5luFgsGneo17P k40VfaF8y0J86ICg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 670E713B97; Thu, 1 Oct 2026 15:57:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yvM5C+2CvmqlUQAAD6G6ig (envelope-from ); Thu, 01 Oct 2026 15:57:33 +0000 Message-ID: <14c21d1f-6be7-4477-8010-3d6439310410@suse.de> Date: Thu, 1 Oct 2026 17:57:32 +0200 Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] drm/kms-helper: Remove struct drm_simple_display_pipe and helpers To: Javier Martinez Canillas , maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, decui@microsoft.com, longli@microsoft.com, ssengar@linux.microsoft.com, andy@kernel.org, gregkh@linuxfoundation.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, sashiko-reviews@lists.linux.dev References: <20261001133736.802604-1-tzimmermann@suse.de> <20261001133736.802604-3-tzimmermann@suse.de> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: EF6B721292 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[redhat.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch,microsoft.com,linux.microsoft.com,linuxfoundation.org]; RCPT_COUNT_TWELVE(0.00)[15]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_TRACE(0.00)[suse.de:+]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.com:url,suse.de:mid,suse.de:email,suse.de:dkim,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; MID_RHS_MATCH_FROM(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: Hi Javier Am 01.10.26 um 16:46 schrieb Javier Martinez Canillas: > Thomas Zimmermann writes: > > Hello Thomas, > >> There are no drivers using struct drm_simple_display_pipe. Remove >> the data type and all related helpers. >> >> The idea behind struct drm_simple_display_pipe was to provide an >> easier way for writing DRM drivers besides regular atomic helpers. >> It turned out to be more complicated. With all drivers being updated >> to use atomic helpers, it's time to remove simple-pipe. Also clean >> up the related TODO items. >> >> Signed-off-by: Thomas Zimmermann >> --- >> Documentation/gpu/todo.rst | 17 -- >> drivers/gpu/drm/drm_gem_atomic_helper.c | 92 ------- >> drivers/gpu/drm/drm_simple_kms_helper.c | 328 ------------------------ >> drivers/staging/fbtft/TODO | 6 +- >> include/drm/drm_gem_atomic_helper.h | 28 -- >> include/drm/drm_simple_kms_helper.h | 56 +--- > There are no more users of struct drm_simple_display_pipe but still some > drivers include the drm_simple_kms_helper.h header. Latest drm-misc-next: > > git grep "drm_simple_kms_helper.h" -- drivers/gpu/drm/*/ | wc -l > 21 > > So it seems you need more preparatory patches. For this patch though: I'll take another look at it, but there's another interface in this header file that is (still) being used by several drivers. The header file still remains in place for now. Best regards Thomas > > Reviewed-by: Javier Martinez Canillas > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)