* [PATCH 1/1] drivers:video: use setup_timer @ 2017-09-21 11:17 ` Allen Pais 2017-10-17 13:10 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Allen Pais @ 2017-09-21 11:17 UTC (permalink / raw) To: linux-kernel; +Cc: b.zolnierkie, linux-fbdev, Allen Pais Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Allen Pais <allen.lkml@gmail.com> --- drivers/video/fbdev/pxa3xx-gcu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c index 933619d..c474751 100644 --- a/drivers/video/fbdev/pxa3xx-gcu.c +++ b/drivers/video/fbdev/pxa3xx-gcu.c @@ -520,9 +520,7 @@ static void pxa3xx_gcu_debug_timedout(unsigned long ptr) QERROR("Timer DUMP"); /* init the timer structure */ - init_timer(&pxa3xx_gcu_debug_timer); - pxa3xx_gcu_debug_timer.function = pxa3xx_gcu_debug_timedout; - pxa3xx_gcu_debug_timer.data = ptr; + setup_timer(&pxa3xx_gcu_debug_timer, pxa3xx_gcu_debug_timeout, ptr); pxa3xx_gcu_debug_timer.expires = jiffies + 5*HZ; /* one second */ add_timer(&pxa3xx_gcu_debug_timer); -- 2.7.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drivers:video: use setup_timer 2017-09-21 11:17 ` [PATCH 1/1] drivers:video: use setup_timer Allen Pais @ 2017-10-17 13:10 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-10-17 13:10 UTC (permalink / raw) To: Allen Pais; +Cc: linux-kernel, linux-fbdev Hi, On Thursday, September 21, 2017 04:35:31 PM Allen Pais wrote: > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Allen Pais <allen.lkml@gmail.com> Thanks for the patch but I've ended applying a bit more complete one from Himanshu Jha: https://lkml.org/lkml/2017/9/28/695 Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-17 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170921110539epcas2p303a5bbfd69d03cfe4e79a0833027eb2f@epcas2p3.samsung.com>
2017-09-21 11:17 ` [PATCH 1/1] drivers:video: use setup_timer Allen Pais
2017-10-17 13:10 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).