From: Claudiu Beznea <claudiu.beznea@microchip.com>
To: thierry.reding@gmail.com, shc_work@mail.ru, kgene@kernel.org,
krzk@kernel.org, linux@armlinux.org.uk, mturquette@baylibre.com,
sboyd@codeaurora.org, jani.nikula@linux.intel.com,
joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
airlied@linux.ie, kamil@wypas.org, b.zolnierkie@samsung.com,
jdelvare@suse.com, linux@roeck-us.net, dmitry.torokhov@gmail.com,
rpurdie@rpsys.net, jacek.anaszewski@gmail.com, pavel@ucw.cz,
mchehab@kernel.org, sean@mess.org, lee.jones@linaro.org,
daniel.thompson@linaro.org, jingoohan1@gmail.com,
milo.kim@ti.com, robh+dt@kernel.org, mark.rutland@arm.com,
corbet@lwn.net, nicolas.ferre@microchip.com,
alexandre.belloni@free-electrons.com
Cc: linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, intel-gfx@lists.freedesktop.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-leds@vger.kernel.org, linux-input@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH v3 10/10] pwm: atmel: add push-pull mode support
Date: Thu, 22 Feb 2018 12:01:21 +0000 [thread overview]
Message-ID: <1519300881-8136-11-git-send-email-claudiu.beznea@microchip.com> (raw)
In-Reply-To: <1519300881-8136-1-git-send-email-claudiu.beznea@microchip.com>
Add support for PWM push-pull mode. This is only supported by SAMA5D2 SoCs.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/pwm/pwm-atmel.c | 40 ++++++++++++++++++++++++++++++++++++----
1 file changed, 36 insertions(+), 4 deletions(-)
diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
index d2482fe28cfa..da4b58c1ecf2 100644
--- a/drivers/pwm/pwm-atmel.c
+++ b/drivers/pwm/pwm-atmel.c
@@ -33,8 +33,11 @@
#define PWM_CMR 0x0
/* Bit field in CMR */
-#define PWM_CMR_CPOL (1 << 9)
-#define PWM_CMR_UPD_CDTY (1 << 10)
+#define PWM_CMR_CPOL BIT(9)
+#define PWM_CMR_UPD_CDTY BIT(10)
+#define PWM_CMR_DTHI BIT(17)
+#define PWM_CMR_DTLI BIT(18)
+#define PWM_CMR_PPM BIT(19)
#define PWM_CMR_CPRE_MSK 0xF
/* The following registers for PWM v1 */
@@ -219,16 +222,19 @@ static int atmel_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
{
struct atmel_pwm_chip *atmel_pwm = to_atmel_pwm_chip(chip);
struct pwm_state cstate;
+ struct pwm_caps caps;
unsigned long cprd, cdty;
u32 pres, val;
int ret;
pwm_get_state(pwm, &cstate);
+ pwm_get_caps(chip, pwm, &caps);
if (state->enabled) {
if (cstate.enabled &&
cstate.polarity = state->polarity &&
- cstate.period = state->period) {
+ cstate.period = state->period &&
+ cstate.mode = state->mode) {
cprd = atmel_pwm_ch_readl(atmel_pwm, pwm->hwpwm,
atmel_pwm->data->regs.period);
atmel_pwm_calculate_cdty(state, cprd, &cdty);
@@ -263,6 +269,18 @@ static int atmel_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
val &= ~PWM_CMR_CPOL;
else
val |= PWM_CMR_CPOL;
+
+ /* PWM mode. */
+ if (caps.modes & PWM_MODE(PUSH_PULL)) {
+ if (state->mode = PWM_MODE(PUSH_PULL)) {
+ val |= PWM_CMR_PPM | PWM_CMR_DTLI;
+ val &= ~PWM_CMR_DTHI;
+ } else {
+ val &= ~(PWM_CMR_PPM | PWM_CMR_DTLI |
+ PWM_CMR_DTHI);
+ }
+ }
+
atmel_pwm_ch_writel(atmel_pwm, pwm->hwpwm, PWM_CMR, val);
atmel_pwm_set_cprd_cdty(chip, pwm, cprd, cdty);
mutex_lock(&atmel_pwm->isr_lock);
@@ -315,6 +333,20 @@ static const struct atmel_pwm_data atmel_pwm_data_v2 = {
},
};
+static const struct atmel_pwm_data atmel_pwm_data_v3 = {
+ .regs = {
+ .period = PWMV2_CPRD,
+ .period_upd = PWMV2_CPRDUPD,
+ .duty = PWMV2_CDTY,
+ .duty_upd = PWMV2_CDTYUPD,
+ },
+ .caps = {
+ .modes = PWM_MODE(NORMAL) |
+ PWM_MODE(COMPLEMENTARY) |
+ PWM_MODE(PUSH_PULL),
+ },
+};
+
static const struct platform_device_id atmel_pwm_devtypes[] = {
{
.name = "at91sam9rl-pwm",
@@ -337,7 +369,7 @@ static const struct of_device_id atmel_pwm_dt_ids[] = {
.data = &atmel_pwm_data_v2,
}, {
.compatible = "atmel,sama5d2-pwm",
- .data = &atmel_pwm_data_v2,
+ .data = &atmel_pwm_data_v3,
}, {
/* sentinel */
},
--
2.7.4
prev parent reply other threads:[~2018-02-22 12:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 12:01 [PATCH v3 00/10] extend PWM framework to support PWM modes Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 01/10] pwm: extend PWM framework with " Claudiu Beznea
2018-02-24 20:49 ` kbuild test robot
2018-02-26 8:11 ` Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 02/10] pwm: clps711x: populate PWM mode in of_xlate function Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 03/10] pwm: cros-ec: " Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 04/10] pwm: pxa: " Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 05/10] pwm: add PWM mode to pwm_config() Claudiu Beznea
2018-02-22 12:33 ` Daniel Thompson
2018-02-22 13:21 ` Claudiu Beznea
2018-02-26 9:57 ` Jani Nikula
2018-02-26 14:24 ` Claudiu Beznea
2018-02-27 10:54 ` Daniel Thompson
2018-02-27 11:40 ` Claudiu Beznea
2018-02-27 15:38 ` Daniel Thompson
2018-02-27 16:15 ` Claudiu Beznea
2018-02-22 13:01 ` Sean Young
2018-02-22 13:23 ` Claudiu Beznea
2018-02-28 19:44 ` Thierry Reding
2018-02-28 20:04 ` Jani Nikula
2018-03-02 9:28 ` Claudiu Beznea
2018-03-02 9:19 ` Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 06/10] pwm: add PWM modes Claudiu Beznea
2018-02-22 17:28 ` Andy Shevchenko
2018-02-22 17:42 ` Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 07/10] pwm: atmel: add pwm capabilities Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 08/10] pwm: add push-pull mode support Claudiu Beznea
2018-02-22 12:01 ` [PATCH v3 09/10] pwm: add documentation for pwm push-pull mode Claudiu Beznea
2018-02-22 12:01 ` Claudiu Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519300881-8136-11-git-send-email-claudiu.beznea@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@free-electrons.com \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jani.nikula@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=jingoohan1@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kamil@wypas.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=milo.kim@ti.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=rpurdie@rpsys.net \
--cc=sboyd@codeaurora.org \
--cc=sean@mess.org \
--cc=shc_work@mail.ru \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).