From: Kees Cook <keescook@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kees Cook <keescook@chromium.org>,
Thomas Winischhofer <thomas@winischhofer.net>,
Sami Tolvanen <samitolvanen@google.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] console: SisUSB2VGA: Drop dummy con_font_get()
Date: Tue, 27 Feb 2018 00:04:18 +0000 [thread overview]
Message-ID: <1519689860-7421-2-git-send-email-keescook@chromium.org> (raw)
In-Reply-To: <1519689860-7421-1-git-send-email-keescook@chromium.org>
As done in commit:
724ba8b30b04 ("console/dummy: leave .con_font_get set to NULL")
This drops the dummy .con_font_get(), as it could leave arguments
uninitialized.
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/usb/misc/sisusbvga/sisusb_con.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb_con.c b/drivers/usb/misc/sisusbvga/sisusb_con.c
index 73f7bde78e11..998df891bdde 100644
--- a/drivers/usb/misc/sisusbvga/sisusb_con.c
+++ b/drivers/usb/misc/sisusbvga/sisusb_con.c
@@ -1358,7 +1358,6 @@ static const struct consw sisusb_dummy_con = {
.con_switch = SISUSBCONDUMMY,
.con_blank = SISUSBCONDUMMY,
.con_font_set = SISUSBCONDUMMY,
- .con_font_get = SISUSBCONDUMMY,
.con_font_default = SISUSBCONDUMMY,
.con_font_copy = SISUSBCONDUMMY,
};
--
2.7.4
next prev parent reply other threads:[~2018-02-27 0:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180227000432epcas2p1408299421426381f05a548283953b064@epcas2p1.samsung.com>
2018-02-27 0:04 ` [PATCH 0/3] console: Expand dummy functions for CFI Kees Cook
2018-02-27 0:04 ` Kees Cook [this message]
2018-02-27 0:04 ` [PATCH 2/3] console: Fill in struct consw argument names Kees Cook
2018-02-27 0:04 ` [PATCH 3/3] console: Expand dummy functions for CFI Kees Cook
2018-02-28 15:09 ` [PATCH 0/3] " Bartlomiej Zolnierkiewicz
2018-02-28 15:14 ` Bartlomiej Zolnierkiewicz
2018-02-28 15:26 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519689860-7421-2-git-send-email-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=samitolvanen@google.com \
--cc=thomas@winischhofer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).