From: Tomasz Figa <t.figa@samsung.com>
To: Vikas Sajjan <vikas.sajjan@linaro.org>
Cc: jg1.han@samsung.com, linux-samsung-soc@vger.kernel.org,
kgene.kim@samsung.com, devicetree-discuss@lists.ozlabs.org,
patches@linaro.org, linaro-kernel@lists.linaro.org,
rpurdie@rpsys.net, FlorianSchandinat@gmx.de,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/2] video: exynos_dp: Add parsing of gpios pins to exynos-dp driver
Date: Tue, 14 May 2013 14:16:38 +0000 [thread overview]
Message-ID: <1528008.HgBKZQmFTy@amdc1227> (raw)
In-Reply-To: <1368536152-13370-2-git-send-email-vikas.sajjan@linaro.org>
Hi Vikas,
On Tuesday 14 of May 2013 18:25:51 Vikas Sajjan wrote:
> Adds GPIO parsing functionality for "LCD backlight" and "LCD enable"
> GPIO pins of exynos dp controller.
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> drivers/video/exynos/exynos_dp_core.c | 45
> +++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+)
>
I don't think that Exynos DP driver is right place for such code. Backlight
and LCD drivers are responsible for backlight and LCD power control using
backlight and LCD subsystems.
IMHO the correct solution would be to either extend existing backlight/lcd
drivers found in drivers/video/backlight to support direct GPIO control and
parse GPIO pins from device tree or create new gpio_bl and gpio_lcd drivers.
CCing Richard, Florian and linux-fbdev.
Best regards,
Tomasz
next parent reply other threads:[~2013-05-14 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1368536152-13370-1-git-send-email-vikas.sajjan@linaro.org>
[not found] ` <1368536152-13370-2-git-send-email-vikas.sajjan@linaro.org>
2013-05-14 14:16 ` Tomasz Figa [this message]
2013-05-16 2:04 ` [PATCH 1/2] video: exynos_dp: Add parsing of gpios pins to exynos-dp driver 한진구
2013-05-17 12:29 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528008.HgBKZQmFTy@amdc1227 \
--to=t.figa@samsung.com \
--cc=FlorianSchandinat@gmx.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rpurdie@rpsys.net \
--cc=vikas.sajjan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox