From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PULL for v3.5] SH Mobile LCDC overlay support
Date: Tue, 15 May 2012 19:19:05 +0000 [thread overview]
Message-ID: <1542928.AI4txoYCM9@avalon> (raw)
In-Reply-To: <5022250.LOHRC1DPLO@avalon>
Hi Florian,
On Sunday 13 May 2012 20:36:29 Florian Tobias Schandinat wrote:
> On 04/24/2012 11:31 AM, Laurent Pinchart wrote:
> > Hi Florian,
> >
> > Could you please pull the following patches that add overlay support for
> > the SH Mobile LCDC ? They have been posted for review as part of a bigger
> > series some time ago.
>
> Well, besides that I dislike everyone inventing his/her own overlay API
> and just not having time to propose something that fits everyone your
> patch looks mostly okay.
This is a topic that we started to discuss at the ELC a couple of months ago.
My goal was to come up with a single API shared between DRM/KMS, FB and V4L2
to handle graphics pipeline configuration. It quickly turned out that there
was not enough shared interest between DRM and V4L2 developers to make this
happen. Should we resume the discussion for FB, or would you rather want a
separate FB-specific API ?
> Two things:
>
> "That's fine, but you need a Documentation/ABI entry for any new sysfs
> file you create." [Greg K-H]
Thank you for reminding me.
> So as far as I understand Gregs statement and your code correct you
> should add such thing.
>
> I'm not convinced that you don't leak resources. Is the memory you
> allocate with dma_alloc_coherent for the overlays really freed after
> normal use and in error paths?
I'm not sure where the cleanup part of the patch went to, but definitely not
in that branch :-/ I'll fix that and resubmit.
--
Best regards,
Laurent Pinchart
prev parent reply other threads:[~2012-05-15 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 11:31 [PULL for v3.5] SH Mobile LCDC overlay support Laurent Pinchart
2012-05-13 20:36 ` Florian Tobias Schandinat
2012-05-15 19:19 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542928.AI4txoYCM9@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).