From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Date: Thu, 02 May 2019 12:01:45 +0000 Subject: Re: [PATCH] backlight: rave-sp: don't touch initial state and register with correct device Message-Id: <1556798505.2590.7.camel@pengutronix.de> List-Id: References: <20190429152919.27277-1-l.stach@pengutronix.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Daniel Thompson , Lee Jones , Jingoo Han Cc: linux-fbdev@vger.kernel.org, kernel@pengutronix.de, dri-devel@lists.freedesktop.org, patchwork-lst@pengutronix.de Hi Daniel, Am Donnerstag, den 02.05.2019, 11:33 +0100 schrieb Daniel Thompson: > On 29/04/2019 16:29, Lucas Stach wrote: > > This way the backlight can be referenced through its device node and > > enabling/disabling can be managed through the panel driver. > > Is it possible to implement something similar to  > pwm_backlight_initial_power_state() to handle this? I'm not aware of any protocol to the RAVE-SP that would allow to read back the backlight state. AFAICS the backlight is implemented as a unidirectional protocol. Regards, Lucas > backlight drivers already suffer from too much diversity so I prefer  > things like this to align behaviour with the (fairly heavilyly used) PWM  > driver if possible. > > > Daniel. > > > > > > Signed-off-by: Lucas Stach > > --- > >   drivers/video/backlight/rave-sp-backlight.c | 4 +--- > >   1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/video/backlight/rave-sp-backlight.c b/drivers/video/backlight/rave-sp-backlight.c > > index 462f14a1b19d..d296bfcf4396 100644 > > --- a/drivers/video/backlight/rave-sp-backlight.c > > +++ b/drivers/video/backlight/rave-sp-backlight.c > > @@ -48,15 +48,13 @@ static int rave_sp_backlight_probe(struct platform_device *pdev) > > > >    struct device *dev = &pdev->dev; > > > >    struct backlight_device *bd; > >    > > > > - bd = devm_backlight_device_register(dev, pdev->name, dev->parent, > > > > + bd = devm_backlight_device_register(dev, pdev->name, dev, > > > >        dev_get_drvdata(dev->parent), > > > >        &rave_sp_backlight_ops, > > > >        &rave_sp_backlight_props); > > > >    if (IS_ERR(bd)) > > > >    return PTR_ERR(bd); > >    > > > > - backlight_update_status(bd); > > - > > > >    return 0; > >   } > >    > > > >