linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] video/fbdev/68328fb: Remove dead code
@ 2019-09-02 12:43 ` Souptick Joarder
  2020-01-03 12:02   ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2019-09-02 12:43 UTC (permalink / raw)
  To: b.zolnierkie
  Cc: dri-devel, linux-fbdev, linux-kernel, sabyasachi.linux,
	Souptick Joarder

This is dead code since 3.15. If their is no plan to
use it further, these can be removed forever.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/video/fbdev/68328fb.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/video/fbdev/68328fb.c b/drivers/video/fbdev/68328fb.c
index d48e960..02d22b7 100644
--- a/drivers/video/fbdev/68328fb.c
+++ b/drivers/video/fbdev/68328fb.c
@@ -405,20 +405,8 @@ static int mc68x328fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 
 int __init mc68x328fb_setup(char *options)
 {
-#if 0
-	char *this_opt;
-#endif
-
 	if (!options || !*options)
 		return 1;
-#if 0
-	while ((this_opt = strsep(&options, ",")) != NULL) {
-		if (!*this_opt)
-			continue;
-		if (!strncmp(this_opt, "disable", 7))
-			mc68x328fb_enable = 0;
-	}
-#endif
 	return 1;
 }
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] video/fbdev/68328fb: Remove dead code
  2019-09-02 12:43 ` [PATCH] video/fbdev/68328fb: Remove dead code Souptick Joarder
@ 2020-01-03 12:02   ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-03 12:02 UTC (permalink / raw)
  To: Souptick Joarder; +Cc: linux-fbdev, linux-kernel, dri-devel, sabyasachi.linux


On 9/2/19 2:49 PM, Souptick Joarder wrote:
> This is dead code since 3.15. If their is no plan to
> use it further, these can be removed forever.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Thanks, patch queued for v5.6 (also sorry for the delay).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/68328fb.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/video/fbdev/68328fb.c b/drivers/video/fbdev/68328fb.c
> index d48e960..02d22b7 100644
> --- a/drivers/video/fbdev/68328fb.c
> +++ b/drivers/video/fbdev/68328fb.c
> @@ -405,20 +405,8 @@ static int mc68x328fb_mmap(struct fb_info *info, struct vm_area_struct *vma)
>  
>  int __init mc68x328fb_setup(char *options)
>  {
> -#if 0
> -	char *this_opt;
> -#endif
> -
>  	if (!options || !*options)
>  		return 1;
> -#if 0
> -	while ((this_opt = strsep(&options, ",")) != NULL) {
> -		if (!*this_opt)
> -			continue;
> -		if (!strncmp(this_opt, "disable", 7))
> -			mc68x328fb_enable = 0;
> -	}
> -#endif
>  	return 1;
>  }
>  

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-03 12:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20190902124317epcas1p3933aec8ee7e526f3f42dd9f08ce6bdb0@epcas1p3.samsung.com>
2019-09-02 12:43 ` [PATCH] video/fbdev/68328fb: Remove dead code Souptick Joarder
2020-01-03 12:02   ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).