From: Javier Martinez Canillas <javierm@redhat.com>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Martin Mares <mj@ucw.cz>, Helge Deller <deller@gmx.de>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Simon Trimmer <simont@opensource.cirrus.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Arnd Bergmann <arnd@arndb.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
David Herrmann <dh.herrmann@gmail.com>,
linux-kernel@vger.kernel.org,
linux-video@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH v3] simplefb: Enable boot time VESA graphic mode selection.
Date: Wed, 23 Feb 2022 18:07:46 +0100 [thread overview]
Message-ID: <15d5a0ce-ca58-e670-99e4-a79e07a0fe22@redhat.com> (raw)
In-Reply-To: <f832a836-b6ee-ffc5-6f83-86c9ba475400@redhat.com>
On 2/23/22 17:54, Javier Martinez Canillas wrote:
> On 2/23/22 17:45, Michal Suchánek wrote:
>
> [snip]
>
>>>>
>>>> To enable use of VESA modes with simplefb in legacy BIOS boot mode drop
>>>
>>> I think you meant "VESA modes with the sysfb driver" ? or something like
>>> that since otherwise it seems that you meant to use it with the simplefb
>>> (drivers/video/fbdev/simplefb.c) fbdev driver, which doesn't support the
>>> "vga=" param as far as I understand (it just uses whatever was setup).
>>
>> And the vga= is whatever was set up by the realmode code. And the config
>> option for realmode code to do that is selected by vesafb and not
>> simplefb so it does not wotk for simplefb/simpledrm/whatewer when efifib
>> is not built into the kernel.
>>
>
> Yes, that's what I tried to say. But your commit message says "To enable
> use of VESA modes with simplefb in legacy BIOS boot mode" and that isn't
> accurate AFAIU (unless you meant sysfb instead).
In fact, probably the subject line should also be something like following:
firmware: sysfb: Enable boot time VESA graphic mode selection
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-02-23 17:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 9:33 [PATCH] simpldrm: Enable boot time VESA graphic mode selection Michal Suchanek
2022-02-18 9:57 ` Thomas Zimmermann
2022-02-18 10:08 ` Michal Suchánek
2022-02-18 10:24 ` Thomas Zimmermann
2022-02-18 10:51 ` [PATCH v2] simplefb: " Michal Suchanek
2022-02-18 11:36 ` Thomas Zimmermann
2022-02-18 12:05 ` Michal Suchánek
2022-02-18 16:04 ` [PATCH v3] " Michal Suchanek
2022-02-21 9:51 ` Thomas Zimmermann
2022-02-23 18:38 ` Borislav Petkov
2022-02-23 16:34 ` Javier Martinez Canillas
2022-02-23 16:45 ` Michal Suchánek
2022-02-23 16:54 ` Javier Martinez Canillas
2022-02-23 17:07 ` Javier Martinez Canillas [this message]
2022-02-23 17:12 ` Michal Suchánek
2022-02-23 18:13 ` Javier Martinez Canillas
2022-02-23 18:23 ` Michal Suchánek
2022-02-23 18:34 ` Javier Martinez Canillas
2022-02-23 19:55 ` Michal Suchánek
2022-02-25 20:51 ` [PATCH v4 1/3] sysfb: Make config option dependencies explicit Michal Suchanek
2022-02-25 22:09 ` Javier Martinez Canillas
2022-02-25 20:51 ` [PATCH v4 2/3] sysfb: Enable boot time VESA graphic mode selection Michal Suchanek
2022-02-25 22:10 ` Javier Martinez Canillas
2022-02-25 20:51 ` [PATCH v4 3/3] efifb: Remove redundant efifb_setup_from_dmi stub Michal Suchanek
2022-02-25 22:11 ` Javier Martinez Canillas
2022-03-02 19:31 ` [PATCH] simpldrm: Enable boot time VESA graphic mode selection Thomas Zimmermann
2022-03-02 19:38 ` Michal Suchánek
2022-03-02 19:47 ` Javier Martinez Canillas
2022-03-04 20:00 ` Thomas Zimmermann
2022-03-04 20:47 ` Javier Martinez Canillas
2022-03-07 14:33 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15d5a0ce-ca58-e670-99e4-a79e07a0fe22@redhat.com \
--to=javierm@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=bp@alien8.de \
--cc=cristian.marussi@arm.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-video@atrey.karlin.mff.cuni.cz \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mingo@redhat.com \
--cc=mj@ucw.cz \
--cc=msuchanek@suse.de \
--cc=robh@kernel.org \
--cc=simont@opensource.cirrus.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=tzimmermann@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).