From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] fbcon: Initialize ops->info early
Date: Mon, 13 Nov 2017 17:20:11 +0000 [thread overview]
Message-ID: <1603816.FMahT1RJZd@amdc3058> (raw)
In-Reply-To: <20171113094546.16593-1-thierry.reding@gmail.com>
On Monday, November 13, 2017 10:45:46 AM Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> During console takeover, which happens for all DRM/KMS setups using the
> fbdev helpers, fbcon_startup() is called before fbcon_init() and as a
> result con2fb_acquire_newinfo() will not be called (info->fbcon_par was
> set to non-NULL in fbcon_startup()) to assign ops->info.
>
> This causes the cursor_timer_handler() to unreference a NULL pointer.
>
> Avoid this by unconditionally assigning ops->info during fbcon_startup()
> so that it will be available early, but keep the additional assignment
> in con2fb_acquire_newinfo() to support console remapping at runtime.
>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Patch queued for 4.15, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2017-11-13 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171113094554epcas3p2eb67a3b7263176dfabc719e3bddb792c@epcas3p2.samsung.com>
2017-11-13 9:45 ` [PATCH] fbcon: Initialize ops->info early Thierry Reding
2017-11-13 17:20 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603816.FMahT1RJZd@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).